InteractiveUtils: access bindings in latest world #60736
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InteractiveUtils provides a number of utilities for querying and
accessing the contents of modules. Because these modules can gain new
bindings, some callers of InteractiveUtils functions produce warnings
WARNING: Detected access to binding ... prior to its definition world.
One dramatic example occurs with the sequence
using OptimizationProblems: OptimizationProblems
using OptimizationProblems.ADNLPProblems
using ADNLPModels: ADNLPModel
when running with Revise. ADNLPProblems loads new problems via Requires,
and starting with v3.13 Revise queries `InteractiveUtils.subtypes` to
cache dependent fieldtypes. This triggers the warning, and because it
runs in a separate task, the `--depwarn=error` trick unfortunately
failed to produce a stacktrace. Thus this was quite difficult to track
down.
Fixes timholy/Revise.jl#993
timholy
added
backport 1.12
Member
Author
|
The main alternative to this approach might be to give |
Member
|
I think it'd prefer if all of these gained a |
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InteractiveUtils provides a number of utilities for querying and accessing the contents of modules. Because these modules can gain new bindings, some callers of InteractiveUtils functions produce warnings
One dramatic example occurs with the sequence
when running with Revise, where it can produce hundreds of warnings. ADNLPProblems loads new problems via Requires, and starting with v3.13 Revise queries
InteractiveUtils.subtypesto cache dependent fieldtypes. This triggers the warning, and because it runs in a separate task, the--depwarn=errortrick unfortunately failed to produce a stacktrace. Thus this was quite difficult to track down.Fixes timholy/Revise.jl#993
CC @aviatesk, @Keno