fix: reduce hint name limit to 150 chars for Windows net472 PATH_MAX#4760
Open
fix: reduce hint name limit to 150 chars for Windows net472 PATH_MAX#4760
Conversation
… net472 The previous limit of 200 chars (from #4757) still caused PathTooLongException on Windows CI because .NET Framework 4.7.2's Path.GetFullPathInternal prepends the CWD (~69 chars) to the hint name, exceeding the hardcoded 260-char MAX_PATH limit. Reducing to 150 leaves ~110 chars of headroom for the working directory. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MaxHintNameLengthfrom 200 to 150 inFileNameHelper.csto fixPathTooLongExceptionon Windows CI withnet472Path.GetFullPathInternalprepends the CWD (~69 chars on CI) to the hint name before validating against the hardcoded 260-charMAX_PATHlimit (200 + 69 = 269 > 260)net8.0/net10.0are unaffected since modern .NET doesn't enforce the legacy path limitTest plan
modularpipeline (windows-latest)CI job passes (specificallynet472source generator tests)🤖 Generated with Claude Code