Skip to content

fix: reduce hint name limit to 150 chars for Windows net472 PATH_MAX #4760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thomhurst wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: reduce hint name limit to 150 chars for Windows net472 PATH_MAX #4760

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion TUnit.Core.SourceGenerator/Helpers/FileNameHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ internal static class FileNameHelper
/// <returns>A deterministic filename like "MyNamespace_MyClass_MyMethod__Int32_String.g.cs"</returns>
// Conservative limit to avoid PathTooLongException on Windows with net472,
// which enforces the legacy 260-character MAX_PATH limit in Roslyn's AddSource.
private const int MaxHintNameLength = 200;
// Roslyn prepends the CWD to the hint name when calling Path.GetFullPathInternal,
// so we must leave ~110 chars of headroom for the working directory path.
private const int MaxHintNameLength = 150;

public static string GetDeterministicFileNameForMethod(INamedTypeSymbol typeSymbol, IMethodSymbol methodSymbol)
{
Expand Down
Loading