fix: truncate long source generator hint names for Windows#4757
Merged
fix: truncate long source generator hint names for Windows#4757
Conversation
…ception on Windows Generic methods with many complex type parameters (e.g. GenericMethodTests.AggregateBy_HasExpectedOutput) generate hint names exceeding 260 characters, which triggers PathTooLongException on Windows with net472 due to the legacy MAX_PATH limit in Roslyn's AddSource. This truncates names exceeding 200 characters and appends a deterministic FNV-1a hash suffix to maintain uniqueness. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. Review SummaryThis PR properly fixes the Windows PathTooLongException by truncating source generator hint names that exceed 200 characters. The implementation:
The approach is well-suited to the problem and follows TUnit development guidelines. |
This was referenced Feb 13, 2026
thomhurst
added a commit
that referenced
this pull request
Feb 13, 2026
… net472 The previous limit of 200 chars (from #4757) still caused PathTooLongException on Windows CI because .NET Framework 4.7.2's Path.GetFullPathInternal prepends the CWD (~69 chars) to the hint name, exceeding the hardcoded 260-char MAX_PATH limit. Reducing to 150 leaves ~110 chars of headroom for the working directory. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
This was referenced Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PathTooLongExceptionon Windows CI (modularpipeline (windows-latest)) that has been failing on every run since theGenericMethodTests.AggregateBy_HasExpectedOutputtest was addedAddSourceonnet472_06BD488B) to maintain uniquenessTest plan
modularpipeline (windows-latest)) passes withoutPathTooLongException🤖 Generated with Claude Code