-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(modal): fixed a bug that disallowed users to set the position of a modal #766
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #766 +/- ##
=======================================
Coverage 99.54% 99.54%
=======================================
Files 129 129
Lines 6537 6537
Branches 391 391
=======================================
Hits 6507 6507
Misses 30 30
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Can you rebase and move these changes to src/theme.ts? We just changed up our repository pretty substantially. You can see the new contributing guide here: https://github.com/themesberg/flowbite-react/blob/main/CONTRIBUTING.md
If you aren't comfortable rebasing, let me know and I'll be happy to do so for you.
7432977
to
5b78768
Compare
@tulup-conner I'm like 96% sure I did that correctly |
…a modal The modal's position property is handled by the parent of the actual content box using flex, align items, and justify content but was being blocked by the content box's proptery of margin: auto. This fix deletes that margin: auto property so the parent can corrently handle the position of the modal correctly. Placement Attribute of the Modal Component doesn't work themesberg#760
Hey I have just used size props for modal
|
Description
The modal's position property is handled by the parent of the actual content box using flex, align-items, and justify-content but was blocked by the content box's property of "margin: auto" (m-auto). This fix deletes that property so the parent can correctly handle the position of the modal correctly.
Fixes #760
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I tested this change by running the documentation site locally and checking whether the property works correctly on the Modal component page.
Checklist: