Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs(Modal): placement doesn't update #780

Closed
zoltanszogyenyi opened this issue May 30, 2023 · 3 comments
Closed

Docs(Modal): placement doesn't update #780

zoltanszogyenyi opened this issue May 30, 2023 · 3 comments
Labels
🐛 bug Something isn't working

Comments

@zoltanszogyenyi
Copy link
Member

Describe the bug

When going to the modal docs page (https://www.flowbite-react.com/docs/components/modal) and browse to the placement options after updating the position the modal preview doesn't reflect this.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://www.flowbite-react.com/docs/components/modal
  2. Scroll down to modal placement
  3. Click on one of the positions
  4. The position is always centered

Expected behavior

The appropiate modal positions should be reflected.

Screenshots

Selected "bottom center" but the modal is still just centered without being on the bottom.

Screenshot 2023-05-30 at 10 49 18

Project information:

  • Tailwind: 3.0.0
  • Flowbite: 1.4.7
  • Flowbite React: 0.1.2
  • Type: CRA

Additional context

None.

@zoltanszogyenyi zoltanszogyenyi added the 🐛 bug Something isn't working label May 30, 2023
@rluders
Copy link
Collaborator

rluders commented May 30, 2023

Interesting, this one was fixed... Do we have a regression here? 🤔

@rluders
Copy link
Collaborator

rluders commented May 30, 2023

Maybe I'm wrong here, but also here is the fix #766

@tulup-conner
Copy link
Collaborator

This is no longer an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants