-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placement Attribute of the Modal Component doesn't work #760
Comments
rtraficante
added a commit
to rtraficante/flowbite-react
that referenced
this issue
May 25, 2023
The positions of the modal are handled by the parent of the actual content box using flex, align items, and justify content properties but were being blocked by the content box's property of margin: auto. This fix takes away the margin auto property to allow the parent to control the position of the content box correctly. Placement Attribute of the Modal Component doesn't work themesberg#760
rtraficante
added a commit
to rtraficante/flowbite-react
that referenced
this issue
May 25, 2023
…orrectly The positions of the modal are handled by the parent of the actual content box using flex, align items, and justify content properties but were being blocked by the content box's property of margin: auto. This fix takes away the margin auto property to allow the parent to control the position of the content box correctly. Placement Attribute of the Modal Component doesn't work themesberg#760
rtraficante
added a commit
to rtraficante/flowbite-react
that referenced
this issue
May 25, 2023
…a modal The modal's position property is handled by the parent of the actual content box using flex, align items, and justify content but was being blocked by the content box's proptery of margin: auto. This fix deletes that margin: auto property so the parent can corrently handle the position of the modal correctly. Placement Attribute of the Modal Component doesn't work themesberg#760
10 tasks
Yeah, this is consistent with the documentation: https://flowbite-react-phi.vercel.app/docs/components/modal We have an open PR that will fix this #766 and I'm waiting for cooperation with the user who submitted that since we just totally rewrote most of the code in this repository. You'll see here once that's been merged. |
rtraficante
added a commit
to rtraficante/flowbite-react
that referenced
this issue
May 26, 2023
…a modal The modal's position property is handled by the parent of the actual content box using flex, align items, and justify content but was being blocked by the content box's proptery of margin: auto. This fix deletes that margin: auto property so the parent can corrently handle the position of the modal correctly. Placement Attribute of the Modal Component doesn't work themesberg#760
rluders
pushed a commit
to rtraficante/flowbite-react
that referenced
this issue
May 30, 2023
…a modal The modal's position property is handled by the parent of the actual content box using flex, align items, and justify content but was being blocked by the content box's proptery of margin: auto. This fix deletes that margin: auto property so the parent can corrently handle the position of the modal correctly. Placement Attribute of the Modal Component doesn't work themesberg#760
rluders
pushed a commit
that referenced
this issue
May 30, 2023
…a modal (#766) The modal's position property is handled by the parent of the actual content box using flex, align items, and justify content but was being blocked by the content box's proptery of margin: auto. This fix deletes that margin: auto property so the parent can corrently handle the position of the modal correctly. Placement Attribute of the Modal Component doesn't work #760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I encountered an issue where the placement attribute of the Modal component is not functioning as expected. Here are the details:
I implemented the Modal component as follows:
However, regardless of the specified position attribute, the Modal continues to appear in the default position. I have also checked the official documentation page for the Modal component at flowbite-react.com/modal, but the mentioned feature does not work there either.
This issue needs attention and should be addressed to ensure the correct functioning of the placement attribute in the Modal component.
The text was updated successfully, but these errors were encountered: