fix(base-cluster/monitoring): add missing kube-prometheus-stack image(s/licenses)#1888
fix(base-cluster/monitoring): add missing kube-prometheus-stack image(s/licenses)#1888
Conversation
📝 WalkthroughWalkthroughUpdated GitHub metadata to add and re-link container image license entries and to modify trusted registry entries for ghcr.io images (adding Changes
Sequence Diagram(s)(omitted — changes are configuration updates without new multi-component control flow) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🔇 Additional comments (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @cwrau, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a configuration oversight by adding the necessary license information and registering the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly adds the missing image ghcr.io/jkroepke/kube-webhook-certgen to the image license and trusted registries configurations. The changes are functional, and the suggestions to improve maintainability by keeping the configuration files sorted are still valid.
There was a problem hiding this comment.
Pull request overview
This PR claims to add "missing kube-prometheus-stack image(s)/licenses" by adding configuration for the ghcr.io/jkroepke/kube-webhook-certgen image to both the trusted registries and image licenses files. However, there is a significant discrepancy: the codebase currently uses registry.k8s.io/ingress-nginx/kube-webhook-certgen:v1.6.5 for kube-prometheus-stack admission webhooks (as documented in Chart.yaml), and there are no configuration changes in this PR that would actually switch to using the jkroepke variant.
Key observations:
- Adds trust configuration for ghcr.io/jkroepke/kube-webhook-certgen
- Adds Apache-2.0 license information for the same image
- No actual usage of this image found in the codebase
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/trusted_registries.yaml | Adds ghcr.io/jkroepke/kube-webhook-certgen to the list of trusted image registries with ALL_TAGS permission |
| .github/image_licenses.yaml | Adds Apache-2.0 license information for ghcr.io/jkroepke/kube-webhook-certgen with a link to the license file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/trusted_registries.yaml (1)
41-42: Entry placement violates alphabetical ordering.The new
jkroepkeentry should be placed beforek8up-io(currently at lines 39-40) to maintain alphabetical order within theghcr.iosection, as 'j' comes before 'k'.📝 Suggested reordering
Move these lines to appear before the k8up-io entry:
teutonet: ALL_IMAGES + jkroepke: + kube-webhook-certgen: ALL_TAGS k8up-io: k8up: ALL_TAGS - jkroepke: - kube-webhook-certgen: ALL_TAGS.github/image_licenses.yaml (1)
125-127: Entry placement violates alphabetical ordering.The new
ghcr.io/jkroepke/kube-webhook-certgenentry should be placed beforeghcr.io/k8up-io/k8up(currently at lines 122-124) to maintain alphabetical order, as 'jkroepke' comes before 'k8up-io'.📝 Suggested reordering
Move these lines to appear before the k8up-io entry:
ghcr.io/teutonet/oci-images/solr-ckan: license: MIT licenseLink: https://github.com/teutonet/oci-images/blob/main/LICENSE + ghcr.io/jkroepke/kube-webhook-certgen: + license: Apache-2.0 + licenseLink: https://raw.githubusercontent.com/jkroepke/kube-webhook-certgen/refs/heads/main/LICENSE ghcr.io/k8up-io/k8up: license: Apache-2.0 licenseLink: https://raw.githubusercontent.com/k8up-io/k8up/refs/heads/master/LICENSE - ghcr.io/jkroepke/kube-webhook-certgen: - license: Apache-2.0 - licenseLink: https://raw.githubusercontent.com/jkroepke/kube-webhook-certgen/refs/heads/main/LICENSE
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/image_licenses.yaml.github/trusted_registries.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Agent
- GitHub Check: wait-for-checks
🔇 Additional comments (1)
.github/image_licenses.yaml (1)
125-127: License link and type verified as correct.The license link is accessible (HTTP 200) and the repository is correctly identified as Apache-2.0 licensed.
Summary by CodeRabbit
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.