chore(base-cluster/license): add license for metrics-server and external-dns#1633
Merged
marvinWolff merged 1 commit intomainfrom Jul 30, 2025
Merged
Conversation
WalkthroughTwo new container image license entries were added to the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
marvinWolff
force-pushed
the
chore/licences/add_missing_licenses
branch
from
9e4c090 to
0a1279b
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/image_licenses.yaml (1)
191-196: Preserve alphabetical order in theregistry.k8s.iogroupThe new entries (
external-dns,metrics-server) are inserted above the existingdeschedulerentry, which breaks the otherwise alphabetical sorting of images inside theregistry.k8s.iosection. Keeping this list sorted makes future look-ups easier and avoids noisy merge conflicts.Suggested reorder:
- registry.k8s.io/external-dns/external-dns: - license: Apache-2.0 - licenseLink: https://github.com/kubernetes-sigs/external-dns/blob/master/LICENSE.md - registry.k8s.io/metrics-server/metrics-server: - license: Apache-2.0 - licenseLink: https://github.com/kubernetes-sigs/metrics-server/blob/master/LICENSE - registry.k8s.io/descheduler/descheduler: - license: Apache-2.0 - licenseLink: https://github.com/kubernetes-sigs/descheduler/blob/master/LICENSE + registry.k8s.io/descheduler/descheduler: + license: Apache-2.0 + licenseLink: https://github.com/kubernetes-sigs/descheduler/blob/master/LICENSE + registry.k8s.io/external-dns/external-dns: + license: Apache-2.0 + licenseLink: https://github.com/kubernetes-sigs/external-dns/blob/master/LICENSE.md + registry.k8s.io/metrics-server/metrics-server: + license: Apache-2.0 + licenseLink: https://github.com/kubernetes-sigs/metrics-server/blob/master/LICENSE
cwrau
requested changes
Jul 29, 2025
marvinWolff
force-pushed
the
chore/licences/add_missing_licenses
branch
from
0a1279b to
af9f85c
Compare
This was referenced Jul 29, 2025
Merged
cwrau
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit