Skip to content

fix(base-cluster): add missing license info#1761

Merged
cwrau merged 1 commit intomainfrom
fix/base-cluster/add-missing-license-info
Oct 22, 2025
Merged

fix(base-cluster): add missing license info#1761
cwrau merged 1 commit intomainfrom
fix/base-cluster/add-missing-license-info

Conversation

@cwrau
Copy link
Copy Markdown
Member

@cwrau cwrau commented Oct 22, 2025

Summary by CodeRabbit

  • Chores
    • Added a new container image registry to the trusted registries configuration with support for all tags.
    • Documented licensing information for the newly added registry entry.

Copilot AI review requested due to automatic review settings October 22, 2025 13:37
@cwrau cwrau enabled auto-merge October 22, 2025 13:37
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds missing license information for the k8up image from the k8up-io organization. The change ensures proper license tracking and registry trust configuration for this component in the base cluster.

Key Changes:

  • Added k8up-io/k8up to the trusted registries list
  • Added Apache-2.0 license information for the k8up image

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/trusted_registries.yaml Added k8up-io registry with k8up image to trusted sources
.github/image_licenses.yaml Added Apache-2.0 license entry for ghcr.io/k8up-io/k8up image

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Oct 22, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Two configuration files are updated with entries for the k8up container image: Apache-2.0 license metadata is added to image_licenses.yaml, and the k8up-io registry is added to trusted_registries.yaml.

Changes

Cohort / File(s) Change Summary
Container Image Configuration
​.github/image_licenses.yaml, ​.github/trusted_registries.yaml
Added k8up image license entry (Apache-2.0) and registry trust configuration for ghcr.io/k8up-io/k8up

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • #1487: Analogous additive changes to both image_licenses.yaml and trusted_registries.yaml for a different container image registry.
  • #1633: Adds license metadata entries to image_licenses.yaml for multiple container images (metrics-server, external-dns).
  • #1445: Adds new image license entries to image_licenses.yaml for container images.

Suggested reviewers

  • tasches
  • marvinWolff

Poem

🐰 K8up hops into the fold so bright,
With Apache's license shining light,
Trusted registries now recognize the friend,
Configuration complete, our configs blend! 📦

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/base-cluster/add-missing-license-info

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5b6ead9 and 82d3ab7.

📒 Files selected for processing (2)
  • .github/image_licenses.yaml (1 hunks)
  • .github/trusted_registries.yaml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cwrau cwrau added this pull request to the merge queue Oct 22, 2025
Merged via the queue into main with commit 76bf09a Oct 22, 2025
7 of 10 checks passed
@cwrau cwrau deleted the fix/base-cluster/add-missing-license-info branch October 22, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants