QVAC-16480 fix: fix kv-cache save race condition in tool-calling completions#1298
Merged
Conversation
gianni-cor
previously approved these changes
Apr 1, 2026
gianni-cor
approved these changes
Apr 1, 2026
NamelsKing
previously approved these changes
Apr 2, 2026
2a86ffb to
985b4ac
Compare
NamelsKing
approved these changes
Apr 3, 2026
lauripiisang
approved these changes
Apr 3, 2026
Contributor
|
/review |
Contributor
Tier-based Approval Status |
opaninakuffo
pushed a commit
to opaninakuffo/qvac
that referenced
this pull request
Apr 13, 2026
opaninakuffo
added a commit
that referenced
this pull request
Apr 13, 2026
* QVAC-16480 fix: fix kv-cache save race condition in tool-calling completions (#1298) * doc: add npm keywords and llms.txt link to README * chore: qvac-sdk v0.8.3 release --------- Co-authored-by: gbl <59838276+gusttav-lang@users.noreply.github.com>
opaninakuffo
added a commit
that referenced
this pull request
Apr 13, 2026
* chore: qvac-sdk v0.8.1 release (#1285) * fix: freeze sdk deps installs in publish and sdk-pod checks (#1288) * chore: update changelog (#1295) * doc[notask]: rewrite SDK README with streamlined quickstart and updated docs links (#1456) * chore[skiplog|notask]: sdk v0.8.3 release, changelog (#1537) * QVAC-16480 fix: fix kv-cache save race condition in tool-calling completions (#1298) * doc: add npm keywords and llms.txt link to README * chore: qvac-sdk v0.8.3 release --------- Co-authored-by: gbl <59838276+gusttav-lang@users.noreply.github.com> * chore[notask|skiplog]: cherry-pick workflow migration from qvac-devops to oss-actions (#1545) * chore: migrate npm publish workflows to use npm trust oidc action of qvac-devops (#1362) * chore: migrate npm publish workflows to use npm trust oidc action * fix: remove the secret token from the workflows * fix: permissions on the workflows for npm trust * refactor: changed the qvac-devops actions to v1.1.8 * refactor: added NPM_TOKEN * feat: reflect package.json changes on the PR * chore: migrate qvac-devops to oss-action (#1478) --------- Co-authored-by: sidj-thr <siddharth.jain@tether.io> * chore: trigger sdk publish workflow (#1548) --------- Co-authored-by: Dmytro Medvinskyi <functionsilence@gmail.com> Co-authored-by: gbl <59838276+gusttav-lang@users.noreply.github.com> Co-authored-by: sidj-thr <siddharth.jain@tether.io>
Proletter
pushed a commit
that referenced
this pull request
May 24, 2026
…letions (#1298) * fix: fix kv-cache save race condition in tool-calling completions * fix: log save errors --------- Co-authored-by: Dmytro Medvinskyi <functionsilence@gmail.com>
Proletter
pushed a commit
that referenced
this pull request
May 24, 2026
* chore: qvac-sdk v0.8.1 release (#1285) * fix: freeze sdk deps installs in publish and sdk-pod checks (#1288) * chore: update changelog (#1295) * doc[notask]: rewrite SDK README with streamlined quickstart and updated docs links (#1456) * chore[skiplog|notask]: sdk v0.8.3 release, changelog (#1537) * QVAC-16480 fix: fix kv-cache save race condition in tool-calling completions (#1298) * doc: add npm keywords and llms.txt link to README * chore: qvac-sdk v0.8.3 release --------- Co-authored-by: gbl <59838276+gusttav-lang@users.noreply.github.com> * chore[notask|skiplog]: cherry-pick workflow migration from qvac-devops to oss-actions (#1545) * chore: migrate npm publish workflows to use npm trust oidc action of qvac-devops (#1362) * chore: migrate npm publish workflows to use npm trust oidc action * fix: remove the secret token from the workflows * fix: permissions on the workflows for npm trust * refactor: changed the qvac-devops actions to v1.1.8 * refactor: added NPM_TOKEN * feat: reflect package.json changes on the PR * chore: migrate qvac-devops to oss-action (#1478) --------- Co-authored-by: sidj-thr <siddharth.jain@tether.io> * chore: trigger sdk publish workflow (#1548) --------- Co-authored-by: Dmytro Medvinskyi <functionsilence@gmail.com> Co-authored-by: gbl <59838276+gusttav-lang@users.noreply.github.com> Co-authored-by: sidj-thr <siddharth.jain@tether.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
"Cannot set new job: a job is already set or being processed"on Linux AppImage/Snap builds_hasActiveResponsewas never cleared📝 How does it solve it?
saveResp.await()so_hasActiveResponseis cleared (via its.finally()) before the generator yields stats and the nextcompletion()call beginsmodel.run()save call inside theif (sessionMsg?.content)guard since saving without a valid cache path always fails🐛 Bug screenshot
🧪 How was it tested?