Skip to content

QVAC-16480 fix: fix kv-cache save race condition in tool-calling completions #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NamelsKing merged 3 commits into from
Apr 3, 2026
Merged

QVAC-16480 fix: fix kv-cache save race condition in tool-calling completions #1298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04e66f0
fix: fix kv-cache save race condition in tool-calling completions
gusttav-lang Apr 1, 2026
985b4ac
fix: log save errors
gusttav-lang Apr 1, 2026
7042baf
Merge branch 'main' into fix/tool-cache
NamelsKing Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/sdk/server/bare/plugins/llamacpp-completion/ops/cache-logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,3 +57,9 @@ export function logCacheDisabled(): void {
export function logCacheSave(sessionPath: string): void {
logger.debug(`[kv-cache] Saving session: ...${sessionPath.slice(-20)}`);
}

export function logCacheSaveError(sessionPath: string, err: unknown): void {
logger.warn(
`[kv-cache] Failed to save session: ...${sessionPath.slice(-20)} — ${err instanceof Error ? err.message : String(err)}`,
);
}
12 changes: 11 additions & 1 deletion packages/sdk/server/bare/plugins/llamacpp-completion/ops/completion-stream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
logCacheDisabled,
logCacheInit,
logCacheSave,
logCacheSaveError,
logCacheStatus,
logMessagesToAddon,
} from "@/server/bare/plugins/llamacpp-completion/ops/cache-logger";
Expand Down Expand Up @@ -234,8 +235,17 @@ async function* processModelResponse(
const sessionMsg = messagesToSend.find((m) => m.role === "session");
if (sessionMsg?.content) {
logCacheSave(sessionMsg.content);
const cachePath = sessionMsg.content;
const saveResp = await model.run([
{ role: "session", content: cachePath },
{ role: "session", content: "save" },
]);
try {
await saveResp.await();
} catch (err: unknown) {
logCacheSaveError(cachePath, err);
}
}
await model.run([{ role: "session", content: "save" }]);
}

const responseWithStats = response as unknown as ResponseWithStats;
Expand Down
Loading