QVAC-16601 test[skiplog]: add kv-cache disk persistence test for tool…#1319
Merged
Conversation
tobi-legan
previously approved these changes
Apr 2, 2026
Contributor
Tier-based Approval Status |
Victor-Rodzko
force-pushed
the
test/kv-cache-tools-save-persistence
branch
from
605a3d1 to
1aff64f
Compare
simon-iribarren
approved these changes
Apr 3, 2026
NamelsKing
approved these changes
Apr 7, 2026
Preview deployments for qvac-docs-staging ⚡️
Commit: Deployment ID: Static site name: |
Contributor
Author
|
/review |
Proletter
pushed a commit
that referenced
this pull request
May 24, 2026
#1319) * QVAC-16601 test[skiplog]: add kv-cache disk persistence test for tool-calling completions * QVAC-16601 test[skiplog]: type kv-cache executor handler signatures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…-calling completions
ATTENTION: should be merged after #1298
What problem does this PR solve?
There was no test coverage for KV-cache disk persistence in tool-calling completion flows. The race condition fixed in #1298 (gusttav-lang/fix/tool-cache) — where the addon silently rejected cache saves without a cache path and
saveResp.await()was not called — could regress without detection.How does it solve it?
kv-cache-tools-sequential-savetest: two sequential streaming completions with tools + shared kvCache keycacheTokensincreases on the second call — proving the save persisted to diskHow was it tested?
secondCacheTokens=304 ≤ firstCacheTokens=316), passes ongusttav-lang/fix/tool-cache(html report attached)kv-cache-local-desktop.html
.binfile with the fixkv-cache-local-ios.html