Skip to content

Conversation

@mdelapenya
Copy link
Member

What does this PR do?

It excludes Testcontainers Cloud from the sonar analysis.

Why is it important?

We don't want duplicated sonar runs, just one.

@mdelapenya mdelapenya requested a review from a team as a code owner May 16, 2025 10:28
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label May 16, 2025
@mdelapenya mdelapenya self-assigned this May 16, 2025
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label May 16, 2025
@netlify
Copy link

netlify bot commented May 16, 2025

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 3765006
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-go/deploys/68271351855c2d000854b87b
😎 Deploy Preview https://deploy-preview-3166--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mdelapenya mdelapenya merged commit 9f737fa into testcontainers:main May 16, 2025
397 of 398 checks passed
@mdelapenya mdelapenya deleted the sonar-refinements branch May 16, 2025 13:14
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request May 19, 2025
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Jun 2, 2025
* main:
  feat(couchbase): adding auth to couchbase initCluster functions to support container reuse (testcontainers#3048)
  chore(deps): bump github.com/containerd/containerd/v2 (testcontainers#3167)
  docs(options): refactor options layout in modules (testcontainers#3163)
  fix(ci): do not run sonar for Testcontainers Cloud (testcontainers#3166)
  chore(ci): do not fail fast in the Testcontainers Cloud run (testcontainers#3164)
  feat: support adding wait strategies as functional option (testcontainers#3161)
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Jun 3, 2025
* main: (236 commits)
  feat(kafka,redpanda): support for waiting for mapped ports without external checks (testcontainers#3165)
  chore: bump ryuk to 0.12.0 (testcontainers#3195)
  feat!: add options when creating RawCommand (testcontainers#3168)
  chore(deps)!: bump github.com/docker/docker from 28.1.1+incompatible to 28.2.2+incompatible (testcontainers#3194)
  feat(couchbase): adding auth to couchbase initCluster functions to support container reuse (testcontainers#3048)
  chore(deps): bump github.com/containerd/containerd/v2 (testcontainers#3167)
  docs(options): refactor options layout in modules (testcontainers#3163)
  fix(ci): do not run sonar for Testcontainers Cloud (testcontainers#3166)
  chore(ci): do not fail fast in the Testcontainers Cloud run (testcontainers#3164)
  feat: support adding wait strategies as functional option (testcontainers#3161)
  fix(etcd): expose ports for the etcd nodes (testcontainers#3162)
  fix(wait): no port to wait for (testcontainers#3158)
  feat: add more functional options for customising containers (testcontainers#3156)
  docs(redpanda): update sasl authentication option to use scram sha 256 (testcontainers#3126)
  chore(deps): bump mkdocs-include-markdown-plugin from 6.2.2 to 7.1.5 (testcontainers#3137)
  chore(deps): bump github.com/shirou/gopsutil/v4 from 4.25.1 to 4.25.4 (testcontainers#3133)
  chore(deps): bump github.com/docker/docker from 28.0.1+incompatible to 28.1.1+incompatible (testcontainers#3152)
  feat(memcached): add memcached module (testcontainers#3132)
  fix(etcd): single node etcd cluster access (testcontainers#3149)
  feat(valkey): add TLS support for Valkey (testcontainers#3131)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Changes that do not impact the existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant