Skip to content

Conversation

@peczenyj
Copy link
Contributor

Highlight that the sasl authentication uses scram sha 256 (I spent some time trying to connect with 512 until I realize my mistake)

What does this PR do?

Update go doc expanding some existing information

Why is it important?

I think we should be explicit about sasl uses scram sha 256

Related issues

N/A

Highlight that the sasl authentication uses scram sha 256 (I spent some time trying to connect with 512 until I realize my mistake)
@peczenyj peczenyj requested a review from a team as a code owner April 25, 2025 20:28
@netlify
Copy link

netlify bot commented Apr 25, 2025

Deploy Preview for testcontainers-go failed.

Name Link
🔨 Latest commit e600f2d
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/681b4899f379b20008e11da1

@peczenyj peczenyj changed the title doc: Update options.go docs: Update options.go Apr 25, 2025
@peczenyj peczenyj changed the title docs: Update options.go docs: update options.go Apr 25, 2025
@peczenyj peczenyj changed the title docs: update options.go docs: update module redpanda options.go Apr 25, 2025
@mdelapenya mdelapenya added the documentation Docs, docs, docs. label Apr 26, 2025
mdelapenya
mdelapenya previously approved these changes Apr 26, 2025
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Could you also update the docs at ./docs/modules/redpanda.md? 🙏

@mdelapenya
Copy link
Member

@peczenyj could you update the ./docs/modules/redpanda.md file with the comments for the option? Once there, we can merge this one

@peczenyj
Copy link
Contributor Author

peczenyj commented May 7, 2025

Done

@mdelapenya mdelapenya changed the title docs: update module redpanda options.go docs(redpanda): update sasl authentication option to use scram sha 256 May 7, 2025
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kicked off the CI, once passed (it will 😄 ) we are good to merge, thanks for your work here with the documentation, they are pretty important to us!

LGTM!

@mdelapenya mdelapenya self-assigned this May 7, 2025
@mdelapenya mdelapenya merged commit d025f0d into testcontainers:main May 7, 2025
13 checks passed
mdelapenya added a commit to waroir20/testcontainers-go that referenced this pull request May 15, 2025
* main:
  feat: support adding wait strategies as functional option (testcontainers#3161)
  fix(etcd): expose ports for the etcd nodes (testcontainers#3162)
  fix(wait): no port to wait for (testcontainers#3158)
  feat: add more functional options for customising containers (testcontainers#3156)
  docs(redpanda): update sasl authentication option to use scram sha 256 (testcontainers#3126)
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Jun 3, 2025
* main: (236 commits)
  feat(kafka,redpanda): support for waiting for mapped ports without external checks (testcontainers#3165)
  chore: bump ryuk to 0.12.0 (testcontainers#3195)
  feat!: add options when creating RawCommand (testcontainers#3168)
  chore(deps)!: bump github.com/docker/docker from 28.1.1+incompatible to 28.2.2+incompatible (testcontainers#3194)
  feat(couchbase): adding auth to couchbase initCluster functions to support container reuse (testcontainers#3048)
  chore(deps): bump github.com/containerd/containerd/v2 (testcontainers#3167)
  docs(options): refactor options layout in modules (testcontainers#3163)
  fix(ci): do not run sonar for Testcontainers Cloud (testcontainers#3166)
  chore(ci): do not fail fast in the Testcontainers Cloud run (testcontainers#3164)
  feat: support adding wait strategies as functional option (testcontainers#3161)
  fix(etcd): expose ports for the etcd nodes (testcontainers#3162)
  fix(wait): no port to wait for (testcontainers#3158)
  feat: add more functional options for customising containers (testcontainers#3156)
  docs(redpanda): update sasl authentication option to use scram sha 256 (testcontainers#3126)
  chore(deps): bump mkdocs-include-markdown-plugin from 6.2.2 to 7.1.5 (testcontainers#3137)
  chore(deps): bump github.com/shirou/gopsutil/v4 from 4.25.1 to 4.25.4 (testcontainers#3133)
  chore(deps): bump github.com/docker/docker from 28.0.1+incompatible to 28.1.1+incompatible (testcontainers#3152)
  feat(memcached): add memcached module (testcontainers#3132)
  fix(etcd): single node etcd cluster access (testcontainers#3149)
  feat(valkey): add TLS support for Valkey (testcontainers#3131)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Docs, docs, docs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants