fix(etcd): single node etcd cluster access #3149

3vilhamster · 2025-05-01T12:33:22Z

What does this PR do?

Added options listen-client-urls and advertise-client-urls for single etcd cluster execution.

Why is it important?

Without this options server cannot handle incoming requests since be default it listens only 127.0.0.1 network interface.

Related issues

Closes [Bug]: Etcd module usage failes with a single node setup #3150

netlify · 2025-05-01T12:34:42Z

✅ Deploy Preview for testcontainers-go ready!

Name	Link
🔨 Latest commit	`348de67`
🔍 Latest deploy log	https://app.netlify.com/sites/testcontainers-go/deploys/68136a15e77eab00082c2dac
😎 Deploy Preview	https://deploy-preview-3149--testcontainers-go.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2025-05-01T12:35:42Z

✅ Deploy Preview for testcontainers-go ready!

Name	Link
🔨 Latest commit	`8961500`
🔍 Latest deploy log	https://app.netlify.com/sites/testcontainers-go/deploys/6813e3904c12110008690e66
😎 Deploy Preview	https://deploy-preview-3149--testcontainers-go.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

stevenh

Thanks for the PR, just some clean up to match our new standards in the test.

modules/etcd/etcd_test.go

stevenh

Thanks for the updates just a few fixes needed and we should be good

modules/etcd/etcd_test.go

stevenh

Thanks again for fixes looks good to me, kicking off tests

…util/v4-4.25.4 * main: chore(deps): bump github.com/docker/docker from 28.0.1+incompatible to 28.1.1+incompatible (#3152) feat(memcached): add memcached module (#3132) fix(etcd): single node etcd cluster access (#3149)

* main: (76 commits) chore(deps): bump mkdocs-include-markdown-plugin from 6.2.2 to 7.1.5 (testcontainers#3137) chore(deps): bump github.com/shirou/gopsutil/v4 from 4.25.1 to 4.25.4 (testcontainers#3133) chore(deps): bump github.com/docker/docker from 28.0.1+incompatible to 28.1.1+incompatible (testcontainers#3152) feat(memcached): add memcached module (testcontainers#3132) fix(etcd): single node etcd cluster access (testcontainers#3149) feat(valkey): add TLS support for Valkey (testcontainers#3131) fix(dockermodelrunner): wait for the model to be pulled (testcontainers#3125) fix(localstack): remove checksum before parsing version (testcontainers#3130) fix(dockermodelrunner): dependency with socat chore: prepare for next minor development cycle (0.38.0) chore: use new version (v0.37.0) in modules and examples fix: handle stopped containers more gracefully when reuse is enabled (testcontainers#3062) feat(gcloud): add option to run firestore in datastore mode (testcontainers#3009) feat: support for mounting images (testcontainers#3044) chore(ci): close PR if it was sent from main (testcontainers#3123) feat: add `WithReuseByName` for modifying Generic Container Requests (testcontainers#3064) chore(deps): bump github/codeql-action from 3.28.15 to 3.28.16 (testcontainers#3120) chore(deps): bump mkdocs-include-markdown-plugin from 6.2.2 to 7.1.5 (testcontainers#3119) chore(deps): bump github.com/magiconair/properties from 1.8.9 to 1.8.10 (testcontainers#3118) chore(ci): exclude more files for a full-blown build (testcontainers#3122) ...

* main: (302 commits) chore(deps): bump mkdocs-include-markdown-plugin from 6.2.2 to 7.1.5 (testcontainers#3137) chore(deps): bump github.com/shirou/gopsutil/v4 from 4.25.1 to 4.25.4 (testcontainers#3133) chore(deps): bump github.com/docker/docker from 28.0.1+incompatible to 28.1.1+incompatible (testcontainers#3152) feat(memcached): add memcached module (testcontainers#3132) fix(etcd): single node etcd cluster access (testcontainers#3149) feat(valkey): add TLS support for Valkey (testcontainers#3131) fix(dockermodelrunner): wait for the model to be pulled (testcontainers#3125) fix(localstack): remove checksum before parsing version (testcontainers#3130) fix(dockermodelrunner): dependency with socat chore: prepare for next minor development cycle (0.38.0) chore: use new version (v0.37.0) in modules and examples fix: handle stopped containers more gracefully when reuse is enabled (testcontainers#3062) feat(gcloud): add option to run firestore in datastore mode (testcontainers#3009) feat: support for mounting images (testcontainers#3044) chore(ci): close PR if it was sent from main (testcontainers#3123) feat: add `WithReuseByName` for modifying Generic Container Requests (testcontainers#3064) chore(deps): bump github/codeql-action from 3.28.15 to 3.28.16 (testcontainers#3120) chore(deps): bump mkdocs-include-markdown-plugin from 6.2.2 to 7.1.5 (testcontainers#3119) chore(deps): bump github.com/magiconair/properties from 1.8.9 to 1.8.10 (testcontainers#3118) chore(ci): exclude more files for a full-blown build (testcontainers#3122) ...

* main: (236 commits) feat(kafka,redpanda): support for waiting for mapped ports without external checks (testcontainers#3165) chore: bump ryuk to 0.12.0 (testcontainers#3195) feat!: add options when creating RawCommand (testcontainers#3168) chore(deps)!: bump github.com/docker/docker from 28.1.1+incompatible to 28.2.2+incompatible (testcontainers#3194) feat(couchbase): adding auth to couchbase initCluster functions to support container reuse (testcontainers#3048) chore(deps): bump github.com/containerd/containerd/v2 (testcontainers#3167) docs(options): refactor options layout in modules (testcontainers#3163) fix(ci): do not run sonar for Testcontainers Cloud (testcontainers#3166) chore(ci): do not fail fast in the Testcontainers Cloud run (testcontainers#3164) feat: support adding wait strategies as functional option (testcontainers#3161) fix(etcd): expose ports for the etcd nodes (testcontainers#3162) fix(wait): no port to wait for (testcontainers#3158) feat: add more functional options for customising containers (testcontainers#3156) docs(redpanda): update sasl authentication option to use scram sha 256 (testcontainers#3126) chore(deps): bump mkdocs-include-markdown-plugin from 6.2.2 to 7.1.5 (testcontainers#3137) chore(deps): bump github.com/shirou/gopsutil/v4 from 4.25.1 to 4.25.4 (testcontainers#3133) chore(deps): bump github.com/docker/docker from 28.0.1+incompatible to 28.1.1+incompatible (testcontainers#3152) feat(memcached): add memcached module (testcontainers#3132) fix(etcd): single node etcd cluster access (testcontainers#3149) feat(valkey): add TLS support for Valkey (testcontainers#3131) ...

[modules][etcd] Fix single node etcd cluster access

348de67

3vilhamster requested a review from a team as a code owner May 1, 2025 12:33

add unit test

32fb8ac

3vilhamster changed the title ~~[modules][etcd] Fix single node etcd cluster access~~ fix: [modules][etcd] Fix single node etcd cluster access May 1, 2025

stevenh changed the title ~~fix: [modules][etcd] Fix single node etcd cluster access~~ fix(etcd): single node etcd cluster access May 1, 2025

stevenh requested changes May 1, 2025

View reviewed changes

modules/etcd/etcd_test.go Outdated Show resolved Hide resolved

adjust test to subtests and fix default configureCMD test

b136a82

3vilhamster requested a review from stevenh May 1, 2025 19:16

stevenh requested changes May 1, 2025

View reviewed changes

modules/etcd/etcd_test.go Outdated Show resolved Hide resolved

modules/etcd/etcd_test.go Outdated Show resolved Hide resolved

modules/etcd/etcd_test.go Outdated Show resolved Hide resolved

fix CleanupContainer before error handling and simplify closure

8961500

3vilhamster requested a review from stevenh May 1, 2025 21:14

stevenh approved these changes May 2, 2025

View reviewed changes

stevenh merged commit 60c7eac into testcontainers:main May 2, 2025
16 checks passed

mdelapenya added the bug An issue with the library label May 2, 2025

mdelapenya mentioned this pull request May 5, 2025

feat(etcd): use testcontainers-go for etcd tests gofiber/storage#1721

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(etcd): single node etcd cluster access #3149

fix(etcd): single node etcd cluster access #3149

Uh oh!

3vilhamster commented May 1, 2025 •

edited

Loading

Uh oh!

netlify bot commented May 1, 2025 •

edited

Loading

Uh oh!

netlify bot commented May 1, 2025 •

edited

Loading

Uh oh!

stevenh left a comment

Uh oh!

Uh oh!

stevenh left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stevenh left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix(etcd): single node etcd cluster access #3149

fix(etcd): single node etcd cluster access #3149

Uh oh!

Conversation

3vilhamster commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Why is it important?

Related issues

Uh oh!

netlify bot commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for testcontainers-go ready!

Uh oh!

netlify bot commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for testcontainers-go ready!

Uh oh!

stevenh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stevenh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stevenh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

3vilhamster commented May 1, 2025 •

edited

Loading

netlify bot commented May 1, 2025 •

edited

Loading

netlify bot commented May 1, 2025 •

edited

Loading