feat(aerospike): add Aerospike module #3094
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@MitulShah1 before moving on with the review, did you know that this module already exists as a community module? https://github.com/ajeetdsouza/testcontainers-aerospike-go What would be the interest of moving it under here? |
I thing this version belongs to official testcontainers-go, what you mention is individual developed. |
|
I know. That module is listed in the modules catalog https://testcontainers.com/modules/aerospike/?language=go Is there anything blocking you from using it? |
|
I can use that module, no problem. |
|
Not opposed to merge this into the main repo, just wanted to know the details |
|
No worries, Thanks i just checked github codebase, next time i'll take care to check official doc as well, if it's listed or not. Meanwhile Closing PR |
|
@mdelapenya I just close PR but when i start work, i saw your comment on https://github.com/ajeetdsouza/testcontainers-aerospike-go/pulls isnt it easy to manage here? At the time I started working on this module, the feature wasn't available in the main repository. I identified the need based on project requirements and decided to proceed with development to avoid delays and to keep my work unblocked. My implementation is aligned with current architecture and standards, and it has already been tested. I believe it offers value by addressing the issue early, and we can either merge it directly or integrate parts of it with the main repo’s version if there are complementary benefits. I’m open to discussing how we can consolidate both efforts efficiently, but the intention was to be proactive and keep momentum going. |
|
Let's reopen an start the discussion and review here. Thanks for pointing out |
mdelapenya
changed the title
|
@mdelapenya thanks for review, suggestion changes are done. |
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
Found some more issues, although I think we are very ready to be in good shape. Thanks for working on this!
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
We broke the docs site in the last commit. I can help you out with that adding commits on top of yours if needed
stevenh
left a comment
stevenh
left a comment
There was a problem hiding this comment.
Late to the party but there's a few bugs which need fixing.
stevenh
left a comment
stevenh
left a comment
There was a problem hiding this comment.
Looking good, just the one bug due to renamed error I think.
stevenh
left a comment
stevenh
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for quick turnaround on fixes most appreciated 👏
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM, thanks @MitulShah1 !
Once merged, could you please update the modules catalog here? https://github.com/testcontainers/community-module-registry/
* main: (91 commits) chore(deps): bump github/codeql-action from 3.28.13 to 3.28.15 (testcontainers#3097) chore(deps): bump golang.org/x/crypto from 0.31.0 to 0.37.0 (testcontainers#3098) feat(aerospike): add Aerospike module (testcontainers#3094) security(compose): upgrade github.com/docker/compose/v2 to fix security vulnerability (testcontainers#3095) feat: add more functional options to the modules API (testcontainers#3070) chore(deps): bump golang.org/x/net in /modules/arangodb (testcontainers#3087) feat: add arangodb module (testcontainers#3083) chore(deps): bump actions/upload-artifact from 4.6.0 to 4.6.2 (testcontainers#3086) chore(deps): bump SonarSource/sonarqube-scan-action from 5.0.0 to 5.1.0 (testcontainers#3085) feat: add socat container (testcontainers#3071) fix(mssql): reduce flakiness in tests (testcontainers#3084) chore: bump golangci-lint to v2 (testcontainers#3082) chore(gcloud): deprecate old gcp containers, creating subpackages for them (testcontainers#3063) fix(mongodb): replica set initialization & connection handling (testcontainers#2984) chore(deps): bump docker/setup-docker-action from 4.2.0 to 4.3.0 (testcontainers#3077) chore(deps): bump github/codeql-action from 3.28.12 to 3.28.13 (testcontainers#3078) chore(deps): bump tj-actions/changed-files from 45.0.4 to 46.0.3 (testcontainers#3076) docs: add dependabot configuration (testcontainers#3074) chore(deps): replace `golang.org/x/exp/slices` with stdlib (testcontainers#3075) fix(dind): use docker image load (testcontainers#3073) ...
* main: chore(deps): bump golang.org/x/crypto in /modules/aerospike (testcontainers#3105) chore(ci): run codeql on the modified modules (testcontainers#3103) docs: fix reference to container types in Run function (testcontainers#3102) chore(deps): bump github.com/golang-jwt/jwt/v5 in /modules/pulsar (testcontainers#3101) chore(pulsar): bump github.com/apache/pulsar-client-go from 0.10.0 to 0.14.0 (testcontainers#3100) chore(clickhouse): bump github.com/ClickHouse/clickhouse-go/v2 from 2.20.0 to 2.34.0 in /modules/clickhouse (testcontainers#3099) chore(deps): bump github/codeql-action from 3.28.13 to 3.28.15 (testcontainers#3097) chore(deps): bump golang.org/x/crypto from 0.31.0 to 0.37.0 (testcontainers#3098) feat(aerospike): add Aerospike module (testcontainers#3094)
3 participants
This PR adds AeroSpike as a module for
What does this PR do?
Why is it important?
Related issues
@stevenh @eddumelendez would appreciate review PR