This repository was archived by the owner on Apr 15, 2025. It is now read-only.
Maintain/aerospike8 #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
reviewed
Apr 7, 2025
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
I left a few comments, I'm not the maintainer of this module but core maintainer in TC 😅
Thanks!
| } | ||
|
|
||
| // RunContainer creates an instance of the Aerospike container type. | ||
| func RunContainer(ctx context.Context, opts ...testcontainers.ContainerCustomizer) (*AerospikeContainer, error) { |
There was a problem hiding this comment.
I'd advocate for deprecating this RunContainer function and use the new APIs: Run(ctx, image string, opts ...)
Would you like to do it in this PR?
| @@ -1,10 +1,10 @@ | |||
| module github.com/ajeetdsouza/testcontainers-aerospike-go | |||
| module github.com/bitcoin-sv/testcontainers-aerospike-go | |||
There was a problem hiding this comment.
bug: updated module path
Suggested change
| module github.com/bitcoin-sv/testcontainers-aerospike-go | |
| module github.com/ajeetdsouza/testcontainers-aerospike-go |
| github.com/stretchr/testify v1.9.0 | ||
| github.com/aerospike/aerospike-client-go/v8 v8.2.0 | ||
| github.com/stretchr/testify v1.10.0 | ||
| github.com/testcontainers/testcontainers-go v0.31.0 |
There was a problem hiding this comment.
suggestion: bump TC to the latest release too
Suggested change
| github.com/testcontainers/testcontainers-go v0.31.0 | |
| github.com/testcontainers/testcontainers-go v0.36.0 |
|
BTW a contributor submitted a PR to testcontainers-go with the Aerospike module: testcontainers/testcontainers-go#3094 It'll be available in the next release, thanks! |
Owner
|
Cool, archiving this repo. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use latest aerospike version (v8) for test containers.