Repository navigation
feat: Add typography shorthand - #589
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 527da37 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploying terrazzo with
|
| Latest commit: |
527da37
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://82c1e38c.terrazzo.pages.dev |
| Branch Preview URL: | https://drwpow-font-shorthand.terrazzo.pages.dev |
Merged
drwpow
pushed a commit
that referenced
this pull request
Jun 7, 2026
* fix(plugin-sass): forward CSS plugin's localID in transform hook The sass transform was setting `localID: token.id` (the dotted DTCG id), which the main `$__token-values` loop in build.ts then turned into a CSS variable name from scratch — bypassing the CSS plugin's `variableName` and producing `var(--color-blue-40)` instead of `var(--pcl-color-blue-40)`. The typography mixins map was unaffected because that loop queries `format: 'css'` directly. Forwarding `token.localID` instead preserves any prefix or casing customization configured via `variableName` on plugin-css. Regression introduced in 2.2.0 (PR #589) when the main loop in build.ts switched from `format: 'css'` to `format: FORMAT_ID`. * test(plugin-sass): update want.scss fixture for forwarded localID The basic fixture configures plugin-css with a 'ds' variableName prefix. With localID now forwarded, the $__token-values Sass map correctly references the --ds- prefixed CSS variables, matching want.css. * docs(plugin-sass): use ds prefix example in changeset
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Reland of #479 by @michaelurban. Full credit and approach goes to them! Adds typography shorthand and fixes errors in Sass plugin
How to Review