Repository navigation
feat: Place color-scheme before CSS properties - #586
Conversation
🦋 Changeset detectedLatest commit: bbc206e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
01a25c8 to
55a599d
Compare
|
Only test failure is from snapshots. If you could update those with |
55a599d to
83ded28
Compare
|
Update: you may want to change your approach somewhat. Before, we were sorting properties alphabetically. But with the addition of #589, we have to make sure that insert order is preserved. Really this is probably a signal we need to move away from an object, because objects should never try and preserve order, and for the most part they didn’t until #589. Anyways, your approach can still work overall and I’m happy to merge this PR! But I think it’ll have to just not be a part of the |
83ded28 to
bbc206e
Compare
|
@drwpow I rebased the PR and made the relevant changes to fit the new approach. There is one test failing on macos but I don't think it's related to this PR. Let me know if that looks good for you. |
drwpow
left a comment
There was a problem hiding this comment.
Looks great, thank you! Agreed, the macos failure is unrelated. I’ll look into it separately. Thank you! 🙂
Changes
Not much, it just place the
color-schemebefore CSS properties.Although there's nothing wrong being at the end, it's usually used on top of CSS props. It also aligns better with the doc examples.
How to Review
Tiny change, nothing to worry about.