fix: Do not register default light and dark themes when settings() context is not available. Fix interop with other frameworks (shadcn-svelte, Skeleton, etc)
#564
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…context is not available. Fix interop with other frameworks (shadcn-svelte, Skeleton, etc)
|
|
🦋 Changeset detectedLatest commit: 7d5ed1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
commit: |
4 tasks
sean-zlai
added a commit
to zipline-ai/chronon
that referenced
this pull request
Mar 6, 2025
…vertent dark mode removal when rendering a component (#480) ## Summary A continuation of an earlier [fix](techniq/svelte-ux#564), if your system is using dark mode, the class would be removed unintentionally on first render of a Svelte UX component. This [fix](techniq/layerstack#33) occurred in `@layerstack/svelte-stores`'s `themeStore` and package bumped in latest Svelte UX version. Also bumped LayerChart version which includes a small legend/tooltip click propagation issue (something we wouldn't have encountered yet since we don't use `<LineChart ontooltipclick={...}>`). ## Before https://github.com/user-attachments/assets/ebed9f72-ae70-4b13-86a3-605949edc083 ## After https://github.com/user-attachments/assets/605d5d75-2341-41ed-9df5-592343a9782b ## Checklist - [ ] Added Unit Tests - [ ] Covered by existing CI - [ ] Integration tested - [ ] Documentation update <!-- av pr metadata This information is embedded by the av CLI when creating PRs to track the status of stacks when using Aviator. Please do not delete or edit this section of the PR. ``` {"parent":"main","parentHead":"","trunk":"main"} ``` --> Co-authored-by: Sean Lynch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, the system theme within
@layerstack/svelte-stores's themeStore will resolve as using dark mode if the system/OS has dark mode enabled ((prefers-color-scheme: dark)) and trigger setting<html class="dark">which will affect other frameworks such as shadcn-svelte and Skeleton).