New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kickstart dynamic og images #1344 #1608

Closed

vasfvitor wants to merge 1,196 commits into tauri-apps:next from vasfvitor:dynamic-og-images

Contributor

vasfvitor commented Oct 11, 2023

Kickstart dynamic og images generation based on reference provided in #1344 with minor fixes

This depends on startlight being updated to 0.11.0. So it sorta depends on #1601

This is not ready as some pages don't have description field in the frontmatter, but have title. In those cases it is returning undefined written on the OG image. Example: /features/commands/

Plus the current design is minimal

preview:

renovate bot and others added 30 commits

December 23, 2022 11:06


          chore(deps): update dependency typedoc-plugin-mdn-links to v2.0.2 (ta…

b4678f4

…uri-apps#1046)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          fix(deps): update dependency bootstrap-icons to v1.10.3 (tauri-apps#1049

0d6bc4e

)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): update dependency @crowdin/crowdin-api-client to v1.20.1 (…

17b2838

…tauri-apps#1048)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): bump json5 from 2.2.1 to 2.2.2 (tauri-apps#1050)

9df9346

Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v2.2.1...v2.2.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          Add thiserror example to command guide (tauri-apps#1029)

a7ba079


          Update webview-versions.md (tauri-apps#1055)

8155f40


          Update app size opt guide (tauri-apps#1061)

264fb73


          [feat]: Sponsor Dimension (tauri-apps#1062)

86c9513


          chore(deps): update dependency @crowdin/cli to v3.9.3 (tauri-apps#1066)

251b8b8

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): update dependency typedoc to v0.23.24 (tauri-apps#1059)

27b5cc0

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): update dependency @crowdin/crowdin-api-client to v1.21.0 (…

a869b34

…tauri-apps#1065)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): update dependency esbuild-loader to v2.21.0 (tauri-apps#…

06bbae9

…1063)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          fix(deps): update dependency react-markdown to v8.0.5 (tauri-apps#1067)

5dd9561

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          fix(deps): update dependency @fontsource/rubik to v4.5.14 (tauri-apps…

7db4773

…#1068)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Remove survey from announcement bar (tauri-apps#1069)

42cf3d1


          Proper links connected in https://tauri.app/about/governance (tauri-a…

7c2d667

…pps#1077)


          Add extra prerequisite in order to develop under windows (tauri-apps#…

8c5afcd

…1060)

* Add extra prerquisite in order to develop under windows

* Implement review feedback

* Update docs/guides/getting-started/prerequisites.md

I agree with your proposed change.

Co-authored-by: Fabian-Lars <[email protected]>

* Update docs/guides/getting-started/prerequisites.md

Co-authored-by: Lorenzo Lewis <[email protected]>

* at link to trunk

* Update docs/guides/getting-started/prerequisites.md

Co-authored-by: Lorenzo Lewis <[email protected]>

Co-authored-by: Fabian-Lars <[email protected]>
Co-authored-by: Lorenzo Lewis <[email protected]>


          fix: Update install instructions for Fedora 37 (tauri-apps#1054)

3d07fd0


          chore(deps): update dependency @crowdin/cli to v3.10.0 (tauri-apps#1078)

79d27d6

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): bump ua-parser-js from 0.7.31 to 0.7.33 (tauri-apps#1084)

020686f

Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.31 to 0.7.33.
- [Release notes](https://github.com/faisalman/ua-parser-js/releases)
- [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md)
- [Commits](faisalman/ua-parser-js@0.7.31...0.7.33)

---
updated-dependencies:
- dependency-name: ua-parser-js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          chore(deps): update dependency @crowdin/crowdin-api-client to v1.21.1 (…

b076215

…tauri-apps#1071)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          docs(api.js): fix heading level in window api docs

29bcd25


          feat: new search index and auto scraping in CI (tauri-apps#1082)

b805cfa

* meilisearch evaluation

* correctly group categories

* dry-run automatic index update

* use api key from secret

* temporarily use default searchbar css

* throw together some fixes for our custom css

* don't overflow/no-wrap title

* Delete algolia.html

* revert SearchBar/index.js changes

* typo

* Switch to meilisearch cloud!!!

* test scraper upload

* revert test

* update netlify action

* line clamp

* don't include function signature in text selector


          fix(deps): update docusaurus monorepo to v2.3.0 (tauri-apps#1085)

1fada2b

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Add meilisearch sponsorship (tauri-apps#1086)

d01f208


          Fix typo (tauri-apps#1087)

62bd41b


          chore(deps): update dependency typescript to v4.9.5 (tauri-apps#1090)

0fa2eb4

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Disable i18n preview (tauri-apps#1095)

08b79f8


          feat: tauri v2.0-alpha.3 release post (tauri-apps#1096)

c91dc7a

* Add version 2 alpha 3 release post

* Fix typo

* Mention exact version

---------

Co-authored-by: Wu Yu Wei <[email protected]>


          fix: tauri v2.0-alpha.3 file name (tauri-apps#1100)

e8d1b46

* Rename 2023-02-03-tauri-2-0-0-alpha-3 .mdx to 2023-02-03-tauri-2-0-0-alpha-3.mdx

* Update author image

---------

Co-authored-by: Wu Yu Wei <[email protected]>

simonhyll and others added 19 commits

September 15, 2023 23:30


          Revert "Add CrabNebula sponsor logo (tauri-apps#1520)" (tauri-apps#1551)

aa2192c

This reverts commit b3214e1.


          fix(deps): update dependency bootstrap-icons to v1.11.1 (tauri-apps#1556

c673ed2

)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          fix(deps): update docusaurus monorepo to v2.4.3 (tauri-apps#1562)

a9d5254

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          fix(docs): Add window arg in splashscreen example, closes tauri-apps#…

69718c8

…1572


          update linux arm instructions, closes tauri-apps#1539 (tauri-apps#1568)

d4522b5

* update linux arm instructions, closes tauri-apps#1539

* add instructions to fix/prevent issues with main packages


          fix: added a space (tauri-apps#1574)

f44666d


          Add CrabNebula sponsor logo (tauri-apps#1552)

9dbfd18

Co-authored-by: Lorenzo Lewis <[email protected]>


          style: tweak hero (tauri-apps#1576)

606467d


          feat: change banner to point to 1.5 release blog post (tauri-apps#1577)

9f41cac


          fix: broken release notes page (tauri-apps#1578)

554733b


          chore(docs): Update Rust & TS docs (tauri-apps#1581)

45203a9

Co-authored-by: FabianLars <[email protected]>


          fix(deps): update dependency apexcharts to v3.43.0 (tauri-apps#1583)

ce7914f

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          feat: smooth bg gradient fade (tauri-apps#1588)

d09e55f

* feat: smooth bg gradient fade

port of tauri-apps#1381 to stable docs

* add z-index to heroContainer


          fix(deps): update dependency @fontsource/rubik to v5.0.14 (tauri-apps…

ab2ee13

…#1584)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          docs: Remove ENABLE_CODE_SIGNING from macos action example

cd68988


          fix(docs): wrong variable name and adjust path in windows signing gui…

6dde9ee

…de (tauri-apps#1591)


          Bump postcss from 8.4.14 to 8.4.31 (tauri-apps#1594)

c57f9fd

Bumps [postcss](https://github.com/postcss/postcss) from 8.4.14 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.14...8.4.31)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>


          fix(deps): update dependency @fontsource/rubik to v5.0.15 (tauri-apps…

77e7956

…#1596)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          feat: update macOS codesign documentation for Tauri 1.5 (tauri-apps#1605

13420cf

netlify bot commented Oct 11, 2023 •

edited

Loading

❌ Deploy Preview for tauri-docs-starlight failed.

Name	Link
🔨 Latest commit	`13420cf`
🔍 Latest deploy log	https://app.netlify.com/sites/tauri-docs-starlight/deploys/6526b43257f5ab0007050811

github-actions bot added the i18n label

Contributor Author

vasfvitor commented Oct 11, 2023

build fail could be related to 80452ee return modification

Member

lorenzolewis commented Oct 11, 2023

Hey @vasfvitor this is so awesome, thank you! I got #1601 merged in so this should be unblocked now. I took a few minutes to mock up a potential design for this based on our current direction if you'd like to take a stab at implementing it:

https://www.figma.com/file/ZgVWAeFQsLbFhUpuQ2kl17/Tauri.app-2.0?type=design&node-id=987%3A5394&mode=design&t=DbZoItgt9mEy7Myg-1

https://www.figma.com/file/ZgVWAeFQsLbFhUpuQ2kl17/Tauri.app-2.0?type=design&node-id=992%3A2233&mode=design&t=DbZoItgt9mEy7Myg-1

https://www.figma.com/file/ZgVWAeFQsLbFhUpuQ2kl17/Tauri.app-2.0?type=design&node-id=992%3A2255&mode=design&t=DbZoItgt9mEy7Myg-1

I think we'll have two different types: 1 for pages, and another for a blog post. I've mocked up a design for each. Let's follow the reference for frontmatter for pages where title is required and description is optional (so we should be able to handle no description https://starlight.astro.build/reference/frontmatter/). Similar for blog posts but where title is required and excerpt is optional (https://github.com/HiDeoo/starlight-blog#frontmatter). I think it would also be good to include the date for a blog post

Open to feedback on any of this and thanks for getting this started! 💜

vasfvitor closed this

vasfvitor force-pushed the dynamic-og-images branch from 80452ee to 13420cf Compare

October 11, 2023 14:41

github-actions bot removed the i18n label

Contributor Author

vasfvitor commented Oct 11, 2023

git mishap, workin on it

Contributor Author

vasfvitor commented Oct 11, 2023 •

edited

Loading

@lorenzolewis I made a mistake (synced with dev branch) but I solved now. I couldn't figure how to fix this pr showing the history from the 'dev' branch tho. I didn't intend to close the pr

Anyways... I'll start to work right away. Thanks for all the information and details

Member

lorenzolewis commented Oct 13, 2023

No worries, we've all been there 😅 Feel free to open another PR when you're ready and just mention this one in it so we have a reference back.

vasfvitor mentioned this pull request

feat: Dynamic og image #1344 #1616

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

58 participants