Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra prerequisite in order to develop under windows #1060

Merged
merged 6 commits into from
Jan 26, 2023

Conversation

JurrianFahner
Copy link

I'm a newbie on Tauri development. And I was trying to get started, but got stuck. I used the powershell method.

The default toolchain I had configured (gnu) is not compatible with the getting started guide. However it is assumed that the msvc toolchain is set as default. When I did configure the msvc toolchain, the problems were resolved.

Maybe it also needs to be added in the powershell script. Where it is mentioned that it is important to install tauri-cli and trunk.

@github-actions
Copy link

github-actions bot commented Jan 8, 2023

🚀 Deployed on https://dev1060--tauri.netlify.app

@github-actions github-actions bot temporarily deployed to pull request January 8, 2023 16:45 Inactive
@FabianLars
Copy link
Member

Thank you! I think we should make that clear on the actual install step. This way users wouldn't end up with 2 toolchains installed either. What do you think?

@github-actions github-actions bot temporarily deployed to pull request January 11, 2023 22:33 Inactive
@JurrianFahner
Copy link
Author

JurrianFahner commented Jan 11, 2023

Thank you! I think we should make that clear on the actual install step. This way users wouldn't end up with 2 toolchains installed either. What do you think?

I think we need to assume that the user would start with rust today. If somebody starts today the person will go to https://www.rust-lang.org/tools/install and needs to download rustup-init.exe.

If you leave everything as default it will lead to the following configuration (I used a clean windows 11 system to test it):
image

So I think the nominal case wouldn't lead to problems. However for a more experienced rust user who has played a while with rust already and who somehow uses a different toolchain, it is important that this user can find the solution to configure the right toolchain.

So I don't think we need to make it clear in the actual install step (because the nominal case wouldn't lead to a problem). Since it is an edge case I updated the docs, so a user can check whether the proper toolchain is selected.

@FabianLars
Copy link
Member

So I don't think we need to make it clear in the actual install step (because the nominal case wouldn't lead to a problem)

It's actually not that uncommon for some reason. Maybe rustup detects existing mingw installations or something. But anyway, it's too common to not have a note that asks users to make sure msvc is selected at install time already. This can be a separate PR but if we integrate it here we could refactor your new section to be explicit about the "If you already have Rust installed make sure msvc is the default" stuff

@JurrianFahner
Copy link
Author

@FabianLars I think your comment has been implemented, can you have a second look?

I agree with your proposed change.

Co-authored-by: Fabian-Lars <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request January 25, 2023 20:56 Inactive
docs/guides/getting-started/prerequisites.md Outdated Show resolved Hide resolved
docs/guides/getting-started/prerequisites.md Outdated Show resolved Hide resolved
docs/guides/getting-started/prerequisites.md Outdated Show resolved Hide resolved
Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@github-actions github-actions bot temporarily deployed to pull request January 26, 2023 11:22 Inactive
@lorenzolewis lorenzolewis merged commit 8c5afcd into tauri-apps:dev Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants