-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new search index and auto scraping in CI #1082
Conversation
🚀 Deployed on https://dev1082--tauri.netlify.app |
@lorenzolewis any last concerns? |
Did you want to update the netlify action along with this PR @FabianLars ? |
i thought i just did 😂 |
okay now i was smart enough to actually click on save 💪 thanks for the reminder |
Is there an easy way to also include some text from the page here as well? If the results aren't matching against anything in the body and only the header then even just a snippet of the first "content" in the page could be useful context in the results. Here's an example of what I mean (and maybe truncating these to a max of 2/3 lines would be a good shout): |
About the first thing: Yes i want to look into it, i think the codeblock prevents it from finding the text = i think it can only find the text if it's immediately below the heading, but need to do a bit of testing to confirm that. maybe we can use line-clamp for the second one. |
Ah, then this is fine since we'll have to rewrite it later for Astro anyway |
i was wrong, meilisearch just doesn't return it unless you typed text that is in that paragraph. i'll take a look at the settings, but this shouldn't need any changes to the tauri-docs repo so we can merge it already. |
No description provided.