Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new search index and auto scraping in CI #1082

Merged
merged 16 commits into from
Jan 27, 2023
Merged

feat: new search index and auto scraping in CI #1082

merged 16 commits into from
Jan 27, 2023

Conversation

FabianLars
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 26, 2023

🚀 Deployed on https://dev1082--tauri.netlify.app

@github-actions github-actions bot temporarily deployed to pull request January 26, 2023 13:17 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 26, 2023 15:11 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 26, 2023 16:06 Inactive
@FabianLars FabianLars changed the title meilisearch evaluation feat: new search index and auto scraping in CI Jan 26, 2023
@github-actions github-actions bot temporarily deployed to pull request January 26, 2023 16:24 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 26, 2023 18:22 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 26, 2023 18:34 Inactive
@FabianLars FabianLars marked this pull request as ready for review January 26, 2023 19:33
@github-actions github-actions bot temporarily deployed to pull request January 26, 2023 19:38 Inactive
@FabianLars FabianLars marked this pull request as draft January 26, 2023 20:12
@FabianLars FabianLars marked this pull request as ready for review January 26, 2023 21:09
@github-actions github-actions bot temporarily deployed to pull request January 26, 2023 21:18 Inactive
@github-actions github-actions bot temporarily deployed to commit January 27, 2023 15:01 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 27, 2023 15:19 Inactive
@FabianLars
Copy link
Member Author

@lorenzolewis any last concerns?

@lorenzolewis
Copy link
Member

Did you want to update the netlify action along with this PR @FabianLars ?

@FabianLars
Copy link
Member Author

i thought i just did 😂

@FabianLars
Copy link
Member Author

okay now i was smart enough to actually click on save 💪 thanks for the reminder

@lorenzolewis
Copy link
Member

Is there an easy way to also include some text from the page here as well? If the results aren't matching against anything in the body and only the header then even just a snippet of the first "content" in the page could be useful context in the results.

Screenshot 2023-01-27 at 16 10 01

Here's an example of what I mean (and maybe truncating these to a max of 2/3 lines would be a good shout):

Screenshot 2023-01-27 at 16 12 03

@github-actions github-actions bot temporarily deployed to pull request January 27, 2023 16:18 Inactive
@FabianLars
Copy link
Member Author

About the first thing: Yes i want to look into it, i think the codeblock prevents it from finding the text = i think it can only find the text if it's immediately below the heading, but need to do a bit of testing to confirm that.

maybe we can use line-clamp for the second one.

@github-actions github-actions bot temporarily deployed to pull request January 27, 2023 17:09 Inactive
@lorenzolewis
Copy link
Member

Ah, then this is fine since we'll have to rewrite it later for Astro anyway

@FabianLars
Copy link
Member Author

i was wrong, meilisearch just doesn't return it unless you typed text that is in that paragraph. i'll take a look at the settings, but this shouldn't need any changes to the tauri-docs repo so we can merge it already.

@FabianLars FabianLars merged commit b805cfa into dev Jan 27, 2023
@FabianLars FabianLars deleted the scraper branch January 27, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants