Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added translation contribution guide #1393

Merged
merged 6 commits into from
Aug 18, 2023
Merged

feat: added translation contribution guide #1393

merged 6 commits into from
Aug 18, 2023

Conversation

dklassic
Copy link
Contributor

@dklassic dklassic commented Aug 15, 2023

Will surely be changed alongside the finalization of the translation workflow.

Some food for thought:

  • Encouraging a translation fork and merge a full page pull request only?
  • If allow partial translation, then how do we handle it?
  • Is it possible to setup a per language terminology file to help with the translation consistency? (Would definitely help but then again we didn't actually use it in back in Crowdin and seems fine.....?)

Todo:

  • Add a translation checklist around code translations
  • Add a translation pull request template
  • Add in i18n specific style guide when needed.

Reference:

@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for tauri-docs-starlight ready!

Name Link
🔨 Latest commit c70681f
🔍 Latest deploy log https://app.netlify.com/sites/tauri-docs-starlight/deploys/64df15b47226710008d361c1
😎 Deploy Preview https://deploy-preview-1393--tauri-docs-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lorenzolewis
Copy link
Member

Another point (I'll add it to the hackMD as well): Do we require commit signing for this? We might talk through it with the people we have in the docs call and if it's something we're wanting to entertain then can pull in security to get their input as well.

Copy link
Member

@lorenzolewis lorenzolewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some general feedback outside of the points you already mentioned.

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
If you notice spelling or grammar errors, typos, or opportunities for better phrasing, open a pull request with your suggested fix. If you see a problem that you aren't sure of or don't have time to fix, open an issue.

#### Broken links
When broken links are found, try to fix them across all translations. Ideally, only update the linked URLs, so that translation changes will definitely not be necessary.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to provide some guidance for how to write links here. i.e. Absolute vs relative links (absolute is preferred), if you include the locale in a link (I believe so, but might need to double-check that behaviour), how to handle headings (such as #link-to-heading).

One extra thing I can look at is adding in a link validator (such as https://github.com/HiDeoo/starlight-links-validator) that we run. This is talked about being added into Starlight natively in the future but I can add this specific integration now if we think we want. That HiDeoo guy is awesome and is very involved in the Starlight ecosystem

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, though not sure if we're supposed to do this here in Translation Guide or in a separate Style Guide.

And yes, I was thinking we'd be adding an action to test on the links when I write up this line. Nice to hear there is already a potential working one and a native one in the future!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure the styles guide (making a note to write one up). Maybe the locale-specific things we could include in the i18n guide and then also link out to the style guide as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! Let's do that.

.github/CONTRIBUTING.md Show resolved Hide resolved
@lorenzolewis
Copy link
Member

Draft PR for link validation: #1395

There's some upstream issues that I listed in that one that we'll need to resolve before we can merge that in, but the maintainer is very responsive so I don't think it will be a blocker for long.

@lorenzolewis
Copy link
Member

@dklassic I think we should also have some guidelines around code translations as well. i.e. do we want code comments to be translated or not.

I know upstream is working on building out a more robust code block component (withastro/starlight#461) using https://github.com/expressive-code/expressive-code, so maybe it's better to specify no translations in code blocks until that gets in place and we know what it looks like?

I don't think it will actually have an impact on the content of the code blocks, it will just be a way to specify meta-info after the opening "```" code block ticks. But maybe better to wait until that lands just to be on the safe side.

@dklassic
Copy link
Contributor Author

Might be good to have a checklist on these stuffs. Let me link Github doc's own translation guide here to be referenced later:
https://github.com/github/docs/blob/main/contributing/translations-for-translators.md

@lorenzolewis
Copy link
Member

Might be good to have a checklist on these stuffs. Let me link Github doc's own translation guide here to be referenced later: https://github.com/github/docs/blob/main/contributing/translations-for-translators.md

That's a really good point. Do you think it'd fit nicely in the TRANSLATING.md file and we can easily add to it as we go along? I do have CI to automatically run pnpm format on commit plus we can catch if a build fails with the Netlify status, so I think we're in decent shape with automation on this front, just would be good to include those common things in the guide.

@lorenzolewis
Copy link
Member

I think if we can get all those changes added to the file then this looks good to merge in to me. We can always add on to it as we go along and learn

@dklassic
Copy link
Contributor Author

Finished writing guidelines. I hope it's not too intimidating.

As for i18n specific styling guide, I haven't thought of anything specific for now. We can probably add it in later after a general styling guide has been made.

@dklassic dklassic marked this pull request as ready for review August 17, 2023 18:31
Copy link
Member

@lorenzolewis lorenzolewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few tweaks, will go ahead and commit those and get this merged in

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/TRANSLATING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/TRANSLATING.md Outdated Show resolved Hide resolved
.github/TRANSLATING.md Outdated Show resolved Hide resolved
.github/TRANSLATING.md Outdated Show resolved Hide resolved
.github/TRANSLATING.md Outdated Show resolved Hide resolved
.github/TRANSLATING.md Outdated Show resolved Hide resolved
.github/TRANSLATING.md Outdated Show resolved Hide resolved
.github/TRANSLATING.md Outdated Show resolved Hide resolved
Copy link
Member

@lorenzolewis lorenzolewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @dklassic ! I'll get this merged, update a few pages to be i18n ready, and will enable maybe Chinese and Spanish locales to start slowing opening this up. I'll give a shout to flapili on Discord to see if they're interested in doing a run-through for a French translation to give any feedback.

@lorenzolewis lorenzolewis merged commit 411e270 into tauri-apps:next Aug 18, 2023
@dklassic dklassic deleted the i18n-guide branch August 18, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants