Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added fr translation for "Why Tauri?" page (test again) #1411

Closed
wants to merge 1 commit into from
Closed

feat: added fr translation for "Why Tauri?" page (test again) #1411

wants to merge 1 commit into from

Conversation

dklassic
Copy link
Contributor

@dklassic dklassic commented Aug 17, 2023

Note

This is a test commit to see how the pr workflow would look like and should not be merged.

This Pull Request is powered by GPT-4 to provide a French translation of "Why Tauri?" page.

I've translated "Why Tauri?" page for fr.

I'm not sure if the English video "Tauri in 100 Seconds" from the source page should be translated into "Tauri en 100 Secondes" or not. Maybe I should leave it as "Tauri in 100 Seconds (Vidéo en anglais)".

Need places to mention page (how? by name and/or by path?) and target language.
Need a place to mention concerns about the translation to ask for feedback.

Extra notes:

  • How should the title be formatted? and again, how should the source page be reference in title?
  • Should pr be enforced to be written in English? or is it okay to write entirely in target language?
  • How to ask for review from locale specific reviewer?
  • Is translator allowed to swap out resources to a more locale specific choice? e.g. a French video explaining Tauri in this case.

Reference:

@netlify
Copy link

netlify bot commented Aug 17, 2023

Deploy Preview for tauri-docs-starlight ready!

Name Link
🔨 Latest commit 5297733
🔍 Latest deploy log https://app.netlify.com/sites/tauri-docs-starlight/deploys/64dddfde8076100008e00f55
😎 Deploy Preview https://deploy-preview-1411--tauri-docs-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the i18n Is this related to translations? label Aug 17, 2023
@dklassic
Copy link
Contributor Author

@lorenzolewis yes it works!
image

@lorenzolewis
Copy link
Member

Amazing! Let's just pretend that it worked on the first try and that I totally didn't have to fight with GitHub actions for a solid hour again 😅

I think we're good to close this and #1404 out and continue over in #1393 to wrap that up now that we have an idea of the flow?

@dklassic
Copy link
Contributor Author

Sounds good to me!

@dklassic dklassic closed this Aug 17, 2023
@dklassic dklassic deleted the i18n-test-pr branch August 17, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Is this related to translations?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants