-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/link validator #1395
Feat/link validator #1395
Conversation
Signed-off-by: Lorenzo Lewis <[email protected]>
Signed-off-by: Lorenzo Lewis <[email protected]>
Signed-off-by: Lorenzo Lewis <[email protected]>
Signed-off-by: Lorenzo Lewis <[email protected]>
✅ Deploy Preview for tauri-docs-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Got this one closer with the update from Before: After: The remaining I think are due to an upstream issue in how links are generated that point to Also noticed there's a few more typos in upstream APIs in Tauri I'll need to PR to get fixed. |
Signed-off-by: Lorenzo Lewis <[email protected]>
Signed-off-by: Lorenzo Lewis <[email protected]>
Looking into this more there are 2 issues I've found:
|
Not an upstream issue, but HiDeoo/starlight-typedoc#14 covers the same problem that's happening here with |
Currently just keeping as a draft while some upstream issues are worked through.
Upstream issues:
entryFileName: index.md
is set (including index in filename). Need to open an issue on thisThere may be additional issues with
typedoc-plugin-markdown
that I noticed in the output. One example is this link:/2/reference/core/js/Namespace.event.md#windowlabel
It should instead be in this format:
/2/reference/core/js/namespaceevent#windowlabel
It could be another issue that I haven't had time to fully dig into yet, so I'll see what I can come up with on that.