Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(template): add prettier.Config type to prettier config and resolve plugin import #602

Merged
merged 5 commits into from
Oct 11, 2022

Conversation

nexxeln
Copy link
Member

@nexxeln nexxeln commented Oct 11, 2022

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

prettier config is now typed and tailwind plugin doesn't complain


@vercel
Copy link

vercel bot commented Oct 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
create-t3-app ✅ Ready (Inspect) Visit Preview Oct 11, 2022 at 7:14AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2022

🦋 Changeset detected

Latest commit: 55d7141

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App labels Oct 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 100
🟢 Accessibility 100
🟢 Best practices 93
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-nexxel-prettier-config-t3-oss.vercel.app/

@juliusmarminge juliusmarminge enabled auto-merge (squash) October 11, 2022 07:14
@juliusmarminge juliusmarminge merged commit 9f86e39 into next Oct 11, 2022
@juliusmarminge juliusmarminge deleted the nexxel/prettier-config branch October 11, 2022 07:16
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
…ve plugin import (t3-oss#602)

* feat(template): add prettier.Config type to prettier config and resolve plugin import

* Create silly-ways-pay.md

* Update cli/template/addons/tailwind/prettier.config.cjs

Co-authored-by: Julius Marminge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants