Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(template): add @types/prettier package to tailwind installer #1009

Closed
maxmellen opened this issue Dec 26, 2022 · 0 comments · Fixed by #1010
Closed

chore(template): add @types/prettier package to tailwind installer #1009

maxmellen opened this issue Dec 26, 2022 · 0 comments · Fixed by #1010
Labels
🌟 enhancement New feature or request

Comments

@maxmellen
Copy link
Contributor

Is your feature request related to a problem? Please describe.

#602 goes through the trouble of adding a type hint to the Prettier config in the Tailwind installer, but the installer doesn't add the prettier type definitions to the project, thus leaving the type hint unable to resolve, i.e. not giving the convenience of auto-completion in VS Code.

Note: The Prettier VS Code extension doesn't seem to automatically provide auto-completion in the Prettier config file when it is named.prettierrc.cjs. I guess this is why the type hint was added in the first place. I wonder if having these type definitions globally installed fix this issue, but I feel like that's the wrong solution.

Describe the solution you'd like to see

The Tailwind installer adds the @types/prettier dependency to the project

Describe alternate solutions

Maybe a comment in the Prettier config file hinting at installing the package?

In an ideal world, I'd like to see Prettier put these type definitions directly into their package (rather than DefinitelyTyped) but I feel like that's not likely to happen for a while

Additional information

No response

@maxmellen maxmellen added the 🌟 enhancement New feature or request label Dec 26, 2022
@maxmellen maxmellen changed the title chore: chore(template): add @types/prettier package to tailwind installer Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant