feat: check node version in next config

[c-ehrlich]

✅ Checklist

• I have followed every step in the contributing guide (updated 2022-10-06).
• The PR title follows the convention we established conventional-commit
• I performed a functional test on my final commit

---

would stop people from running into #1600 (comment)

💯

[changeset-bot]

🦋 Changeset detected

Latest commit: 34f44d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
create-t3-app	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
create-t3-app	✅ Ready (Inspect)	Visit Preview	Oct 18, 2023 8:19pm
t3-upgrade	✅ Ready (Inspect)	Visit Preview	Oct 18, 2023 8:19pm

[github-actions]

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🟢 Performance	92
🟢 Accessibility	100
🟢 Best practices	100
🟢 SEO	100
🔴 PWA	30

Lighthouse ran on https://create-t3-app-git-check-node-version-t3-oss.vercel.app/

[juliusmarminge]

I think 18.13 should be fine, if it's the same bug we had for uploadthing with the fetch api

could we not just set the engines field in package json instead?

[sscotth]

should this be major === 18 && minor < 16?

Same on cli/template/extras/config/next-config-appdir.mjs

[juliusmarminge]

16 is EOL

[sscotth]

I think you misread minor, his check is "<18.6" not "<18.16".

Since you mentioned it, since v19 is also EOL as of 2023-06-01, should we remove v19 all together and check for v20+?

[c-ehrlich]

yes, thanks :)

[c-ehrlich]

I think 18.13 should be fine, if it's the same bug we had for uploadthing with the fetch api

could we not just set the engines field in package json instead?

i dont think its possible to specify multiple versions? 20 is becoming LTR in a few days, so we could just require that, but would probably mean we also need to update docker docs etc

[juliusmarminge]

I think 18.13 should be fine, if it's the same bug we had for uploadthing with the fetch api
could we not just set the engines field in package json instead?

i dont think its possible to specify multiple versions? 20 is becoming LTR in a few days, so we could just require that, but would probably mean we also need to update docker docs etc

"engines": {
  "node": "^18.16 || ^19.7 || >=20"
}

Doesnt' that work?

[sscotth]

Next just bumped their Node version to >=18.17.0 in v13.5.6-canary, bumped to 13.5.7, now it's a major version bump v14.

vercel/next.js#56896
vercel/next.js#56943