Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lower Node.js version requirement #56943

Merged
merged 10 commits into from
Oct 17, 2023
Merged

chore: lower Node.js version requirement #56943

merged 10 commits into from
Oct 17, 2023

Conversation

balazsorban44
Copy link
Member

No description provided.

@ijjk ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. created-by: Next.js team PRs by the Next.js team. type: next labels Oct 17, 2023
packages/next/package.json Outdated Show resolved Hide resolved
huozhi
huozhi previously approved these changes Oct 17, 2023
styfle
styfle previously approved these changes Oct 17, 2023
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also update CI to ensure that tests pass against this version

@ijjk
Copy link
Member

ijjk commented Oct 17, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js chore/lower-node Change
buildDuration 13.9s 10.5s N/A
buildDurationCached 6s 6.2s ⚠️ +224ms
nodeModulesSize 174 MB 174 MB
nextStartRea..uration (ms) 529ms 535ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js chore/lower-node Change
199-HASH.js gzip 27.5 kB 27.5 kB
3f784ff6-HASH.js gzip 53.1 kB 53.1 kB
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.3 kB 45.3 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 32.9 kB 32.9 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 126 kB 126 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js chore/lower-node Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js chore/lower-node Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.57 kB 2.57 kB N/A
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.35 kB 4.35 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.64 kB 2.63 kB N/A
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.08 kB 1.08 kB
Client Build Manifests
vercel/next.js canary vercel/next.js chore/lower-node Change
_buildManifest.js gzip 485 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js chore/lower-node Change
index.html gzip 528 B 529 B N/A
link.html gzip 541 B 543 B N/A
withRouter.html gzip 524 B 524 B
Overall change 524 B 524 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js chore/lower-node Change
edge-ssr.js gzip 93.7 kB 93.7 kB N/A
page.js gzip 154 kB 154 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js chore/lower-node Change
middleware-b..fest.js gzip 625 B 622 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.5 kB 22.5 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: e1a8fd1

@vercel-release-bot vercel-release-bot dismissed stale reviews from huozhi and styfle via b44fd99 October 17, 2023 16:36
@ijjk
Copy link
Member

ijjk commented Oct 17, 2023

Failing test suites

Commit: 84dca06

pnpm test test/integration/create-next-app/package-manager.test.ts

  • should use Yarn as the package manager on supplying --use-yarn

  • should infer yarn as the package manager

Expand output

● should use Yarn as the package manager on supplying --use-yarn

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  81 |   for (const file of files) {
  82 |     try {
> 83 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  84 |     } catch (err) {
  85 |       require('console').error(
  86 |         `missing expected file ${file}`,

  at projectFilesShouldExist (integration/create-next-app/lib/utils.ts:83:54)
  at integration/create-next-app/package-manager.test.ts:106:28
  at useTempDir (lib/use-temp-dir.ts:24:5)
  at Object.<anonymous> (integration/create-next-app/package-manager.test.ts:86:3)

● should infer yarn as the package manager

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  81 |   for (const file of files) {
  82 |     try {
> 83 |       expect(existsSync(resolve(projectRoot, file))).toBe(true)
     |                                                      ^
  84 |     } catch (err) {
  85 |       require('console').error(
  86 |         `missing expected file ${file}`,

  at projectFilesShouldExist (integration/create-next-app/lib/utils.ts:83:54)
  at integration/create-next-app/package-manager.test.ts:416:28
  at useTempDir (lib/use-temp-dir.ts:24:5)
  at Object.<anonymous> (integration/create-next-app/package-manager.test.ts:388:3)

Read more about building and testing Next.js in contributing.md.

@ijjk ijjk requested a review from a team as a code owner October 17, 2023 17:02
ijjk
ijjk previously approved these changes Oct 17, 2023
@ijjk ijjk requested review from ismaelrumzan and delbaoliveira and removed request for a team October 17, 2023 17:02
@feedthejim feedthejim merged commit 523474c into canary Oct 17, 2023
54 of 59 checks passed
@feedthejim feedthejim deleted the chore/lower-node branch October 17, 2023 21:15
balazsorban44 added a commit that referenced this pull request Oct 18, 2023
kodiakhq bot pushed a commit that referenced this pull request Oct 20, 2023
### What?

`globalThis.ReadableStream` and `globalThis.WriteableStream` has been exposed since Node.js 18, which is our new default requirement. (#56943)

### Why?

This simplifies the code and might result in slightly better performance.

### How?

Drop any checks of `globalThis` properties that are always defined now.
@github-actions github-actions bot added the locked label Nov 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. created-by: Next.js team PRs by the Next.js team. locked type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants