feat(documentation): migrate collapsible to storybook v7 + lit#1656
Conversation
|
|
Preview environment ready: https://preview-1656--swisspost-design-system-next-v7.netlify.app |
25252f7 to
1ac7514
Compare
alizedebray
left a comment
There was a problem hiding this comment.
There is an issu with the heading-level/headingLevel control:

It is probably du to extractArgTypesFactory which has recently been removed from @pxtrn/storybook-addon-docs-stencil :

alizedebray
left a comment
There was a problem hiding this comment.
I am wondering if we need all the stories here:

For me, "Default" and "Custom Trigger" should remain, but the other 3 can be hidden and used only in the documentation as they are a simple variant of the "Default" story.
@imagoiq @oliverschuerch @gfellerph do you have a different opinion?
@alizedebray we can show a smaller set of stories (or even the docs page only) for components that have only small variations. The header on the other hand profits from multiple stories because you can change the layout dramatically with fullscreen and hidden meta navigation. Something else @alizedebray, @imagoiq: the styles seem to be off https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=9989-50310&mode=design&t=CY1q4A6PCRSJ9lro-4. Is this intentional? |
@gfellerph it is tracked with issue #1291, there is also a PR #1324 |
Thanks I think that it's ready to be merged then. |
|
Kudos, SonarCloud Quality Gate passed!
|









No description provided.