Skip to content

fix(styles): fix collapsible component styles#1324

Merged
alizedebray merged 17 commits into
mainfrom
1291-collapsible-styles-are-broken-after-bootstrap-update
Aug 4, 2023
Merged

fix(styles): fix collapsible component styles#1324
alizedebray merged 17 commits into
mainfrom
1291-collapsible-styles-are-broken-after-bootstrap-update

Conversation

@alizedebray

@alizedebray alizedebray commented Mar 31, 2023

Copy link
Copy Markdown
Contributor

I took advantage of the accordion display issue fix to remove the Bootstrap styles.

@alizedebray alizedebray linked an issue Mar 31, 2023 that may be closed by this pull request
Collapsible styles are broken after bootstrap update #1291
Closed
@changeset-bot

changeset-bot Bot commented Mar 31, 2023 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 54dad49

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@swisspost/design-system-components Patch
@swisspost/design-system-styles Patch
@swisspost/design-system-components-react Patch
@swisspost/design-system-documentation-v7 Patch
@swisspost/design-system-documentation Patch
@swisspost/design-system-components-angular Patch
@swisspost/design-system-demo Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sonarqubecloud

sonarqubecloud Bot commented Mar 31, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@swisspost-bot

swisspost-bot commented Mar 31, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Preview environment ready: https://preview-1324--swisspost-design-system-next.netlify.app
Preview environment ready: https://preview-1324--swisspost-web-frontend.netlify.app
Preview environment ready: https://preview-1324--swisspost-design-system-next-v7.netlify.app

oliverschuerch
oliverschuerch requested changes Apr 17, 2023
View reviewed changes
Comment thread packages/styles/src/components/accordion.scss Outdated
Comment thread packages/styles/src/components/accordion.scss Outdated
@alizedebray alizedebray marked this pull request as draft June 5, 2023 12:16
@alizedebray alizedebray mentioned this pull request Jul 28, 2023
Merged
@alizedebray alizedebray marked this pull request as ready for review July 28, 2023 10:32
@alizedebray alizedebray requested a review from imagoiq as a code owner July 28, 2023 10:32
@alizedebray alizedebray force-pushed the 1291-collapsible-styles-are-broken-after-bootstrap-update branch from 2b1b3b0 to 9bb0981 Compare July 28, 2023 10:34
imagoiq
imagoiq approved these changes Jul 31, 2023
View reviewed changes
Comment thread pnpm-lock.yaml
@@ -1,4 +1,4 @@
lockfileVersion: '6.0'
lockfileVersion: '6.1'

@imagoiq imagoiq Jul 31, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It came several time in PRs, I think we should leave it as it. I guess the tool is right

Comment thread packages/styles/src/components/accordion.scss Outdated
@alizedebray alizedebray force-pushed the 1291-collapsible-styles-are-broken-after-bootstrap-update branch from 49e6897 to 463cf77 Compare August 3, 2023 14:10
gfellerph

This comment was marked as outdated.

Sign in to view

gfellerph
gfellerph requested changes Aug 3, 2023
View reviewed changes
Comment thread packages/styles/src/mixins/_icons.scss
Comment thread packages/styles/src/components/accordion.scss
@alizedebray @gfellerph
Update packages/styles/src/mixins/_icons.scss
910ceb8 
Co-authored-by: Philipp Gfeller <1659006+gfellerph@users.noreply.github.com>
@alizedebray alizedebray force-pushed the 1291-collapsible-styles-are-broken-after-bootstrap-update branch from 4241da7 to 03d710a Compare August 4, 2023 09:06
@alizedebray alizedebray force-pushed the 1291-collapsible-styles-are-broken-after-bootstrap-update branch from 03d710a to 73ed213 Compare August 4, 2023 09:12
@alizedebray alizedebray requested a review from gfellerph August 4, 2023 09:15
@sonarqubecloud

sonarqubecloud Bot commented Aug 4, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

gfellerph
gfellerph approved these changes Aug 4, 2023
View reviewed changes

@gfellerph gfellerph left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @alizedebray! Nice to see one less bootstrap-dependent component 💪

As an aside / personal opinion: exclusive accordions should die in a hellish fire; they deserve nothing more after all the frustration they’ve caused me and countless others—please let me see content when and how I want it…

@alizedebray alizedebray merged commit 427d611 into main Aug 4, 2023
@alizedebray alizedebray deleted the 1291-collapsible-styles-are-broken-after-bootstrap-update branch August 4, 2023 15:06
@github-actions github-actions Bot mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gfellerph gfellerph gfellerph approved these changes

@oliverschuerch oliverschuerch oliverschuerch approved these changes

+1 more reviewer

@imagoiq imagoiq imagoiq approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@imagoiq imagoiq

@alizedebray alizedebray

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Collapsible styles are broken after bootstrap update

5 participants

@alizedebray @swisspost-bot @gfellerph @oliverschuerch @imagoiq