Skip to content

feat(textarea): update resizer to match figma for webkit#1516

Closed
RedlineTriad wants to merge 2 commits into
swisspost:mainfrom
RedlineTriad:feature/custom-textarea-resizer
Closed

feat(textarea): update resizer to match figma for webkit#1516
RedlineTriad wants to merge 2 commits into
swisspost:mainfrom
RedlineTriad:feature/custom-textarea-resizer

Conversation

@RedlineTriad

Copy link
Copy Markdown
Contributor

fire and forget

@changeset-bot

changeset-bot Bot commented Jun 14, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e68a554

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@swisspost-bot

swisspost-bot commented Jun 14, 2023

Copy link
Copy Markdown
Contributor

Preview environment ready: https://preview-1516--swisspost-web-frontend.netlify.app
Preview environment ready: https://preview-1516--swisspost-design-system-next.netlify.app
Preview environment ready: https://preview-1516--swisspost-design-system-next-v7.netlify.app

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@oliverschuerch oliverschuerch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work in Firefox!

"This feature is non-standard and should not be used without careful consideration."

Source: caniuse.com

@RedlineTriad

Copy link
Copy Markdown
Contributor Author

Thats why I mentioned it in the title that it will only work for webkit, but @gfellerph said that it would still be an improvement.

@gfellerph

Copy link
Copy Markdown
Member

Thats why I mentioned it in the title that it will only work for webkit, but @gfellerph said that it would still be an improvement.

I'd call it progressive enhancement. It's non-critical for the correct functioning of the text-area, just looks nice for the browsers that support it.

@gfellerph gfellerph added the open-source-day-june-2023 Tickets for people who'd like to get involved. label Jun 15, 2023
@oliverschuerch oliverschuerch linked an issue Aug 4, 2023 that may be closed by this pull request
@oliverschuerch

Copy link
Copy Markdown
Contributor

Duplicate of #1765.

@sonarqubecloud

sonarqubecloud Bot commented Aug 8, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-day-june-2023 Tickets for people who'd like to get involved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Styles: Textarea

4 participants