Skip to content

fix: avoid duplicating escaped characters when parsing styles#17554

Merged
Rich-Harris merged 4 commits intomainfrom
fix-css-parsing-escaped-char
Jan 27, 2026
Merged

fix: avoid duplicating escaped characters when parsing styles#17554
Rich-Harris merged 4 commits intomainfrom
fix-css-parsing-escaped-char

Conversation

@teemingc
Copy link
Member

@teemingc teemingc commented Jan 27, 2026

Unblocks sveltejs/kit#15153 (comment)

This PR ensures that escaped characters are handled correctly when storing the value of a CSS declaration. Previously, it was duplicating it.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2026

🦋 Changeset detected

Latest commit: 352785b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@17554

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could early-continue from the first two branches and keep the value += char where it is, it might be a tiny bit cleaner. but LGTM either way

@Rich-Harris Rich-Harris merged commit 83eb9da into main Jan 27, 2026
18 checks passed
@Rich-Harris Rich-Harris deleted the fix-css-parsing-escaped-char branch January 27, 2026 15:50
@github-actions github-actions bot mentioned this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants