Skip to content

fix: avoid duplicating escaped characters when parsing styles #17554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich-Harris merged 4 commits into from
Jan 27, 2026
Merged

fix: avoid duplicating escaped characters when parsing styles #17554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9dd05cd
fix and test
teemingc Jan 27, 2026
1ae5cb9
changeset
teemingc Jan 27, 2026
500bd32
format
teemingc Jan 27, 2026
352785b
increment index and escape early instead
teemingc Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/true-berries-behave.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: avoid duplicating escaped characters in CSS AST
4 changes: 4 additions & 0 deletions packages/svelte/src/compiler/phases/1-parse/read/style.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,8 +508,12 @@ function read_value(parser) {
if (escaped) {
value += '\\' + char;
escaped = false;
parser.index++;
continue;
} else if (char === '\\') {
escaped = true;
parser.index++;
continue;
} else if (char === quote_mark) {
quote_mark = null;
} else if (char === ')') {
Expand Down
15 changes: 15 additions & 0 deletions packages/svelte/tests/css-parse.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,4 +135,19 @@ describe('parseCss', () => {
}
}
});

it('parses escaped characters', () => {
const ast = parseCss("div { background: url('./example.png?\\''); }");
assert.equal(ast.type, 'StyleSheet');
assert.equal(ast.children.length, 1);
const rule = ast.children[0];
assert.equal(rule.type, 'Rule');
if (rule.type === 'Rule') {
const declaration = rule.block.children[0];
assert.equal(declaration.type, 'Declaration');
if (declaration.type === 'Declaration') {
assert.equal(declaration.value, "url('./example.png?\\'')");
}
}
});
});
Loading