-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove 'implements' from class declaration #14749
Conversation
🦋 Changeset detectedLatest commit: 54ba0bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ca46553
to
88dbb7f
Compare
|
I think it make sense...can you add a test for this? |
@paoloricciuti Thanks Of course, I’d like to add a test, but I can’t figure out the appropriate place for it. |
I would just add a "smoke test" in
<script lang="ts">
interface MyInterface {}
class MyClass implements MyInterface {}
</script> and import { test } from '../../assert';
export default test({}); this is failing on |
Many thanks for your kind guidance! I’ve added the test as suggested. I’ve also confirmed it fails on the main branch. |
Great...let's wait on greens! Thanks a lot! |
related: #14743 #14744 @Rich-Harris
This PR fixes a compilation issue that occurs when esrap 1.3.0 or later is used.
When compiling the following component...
...the following error occurs:
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint