Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove 'implements' from class declaration #14749

Merged
merged 2 commits into from
Dec 18, 2024
Merged

fix: remove 'implements' from class declaration #14749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88dbb7f
fix: remove implements from class declaration
ciscorn Dec 18, 2024
54ba0bb
add a smoke test
ciscorn Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/calm-maps-cover.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: remove implements from class declarations
1 change: 1 addition & 0 deletions packages/svelte/src/compiler/phases/1-parse/remove_typescript_nodes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ const visitors = {
if (node.declare) {
return b.empty;
}
delete node.implements;
return context.next();
},
VariableDeclaration(node, context) {
Expand Down
3 changes: 3 additions & 0 deletions packages/svelte/tests/runtime-browser/samples/typescript-class-and-interface/_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import { test } from '../../assert';

export default test({});
5 changes: 5 additions & 0 deletions packages/svelte/tests/runtime-browser/samples/typescript-class-and-interface/main.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<script lang="ts">
// TypeScript syntax should not cause compilation failure
interface MyInterface {}
class MyClass implements MyInterface {}
</script>
Loading