Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adapter-node regression #1756

Merged
merged 2 commits into from
Jun 24, 2021
Merged

Fix adapter-node regression #1756

merged 2 commits into from
Jun 24, 2021

Conversation

Conduitry
Copy link
Member

Followup to #1754. Oops. I was writing env.js to the wrong place. It worked locally because where I wrote it to was the files directory that was copied over next build. This should be getting written directly to .svelte-kit/node/env.js after copying over everything in files in the package.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@changeset-bot
Copy link

changeset-bot bot commented Jun 24, 2021

🦋 Changeset detected

Latest commit: 8c7b561

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry Conduitry merged commit aa5cf15 into sveltejs:master Jun 24, 2021
@Conduitry Conduitry deleted the gh-1752-b branch June 24, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant