Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow customisation of HOST and PORT env vars in adapter-node #1754

Merged
merged 6 commits into from
Jun 24, 2021

Conversation

Conduitry
Copy link
Member

Resolves #1752.

I'm definitely open to other names for this configuration, because I'm not thrilled on what I currently have. If someone has a better idea of what to say in the adapter's readme, I'd also like to hear about that.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@changeset-bot
Copy link

changeset-bot bot commented Jun 24, 2021

🦋 Changeset detected

Latest commit: 0185aaa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@arxpoetica arxpoetica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

packages/adapter-node/index.js Outdated Show resolved Hide resolved
packages/adapter-node/README.md Outdated Show resolved Hide resolved
@Conduitry Conduitry merged commit 1c8bdba into sveltejs:master Jun 24, 2021
@Conduitry Conduitry deleted the gh-1752 branch June 24, 2021 19:24
@Conduitry Conduitry mentioned this pull request Jun 24, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to customize which environment variables are used for HOST/PORT in Node adapter
4 participants