fix (desktop): make app go brr by AviPeltz · Pull Request #659 · superset-sh/superset

AviPeltz · 2026-01-07T23:55:42Z

Description

Related Issues

Type of Change

Testing

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

Release Notes

Documentation
- Added input lag analysis and performance fix documentation.
Performance Improvements
- Optimized component rendering to reduce unnecessary re-renders.
- Debounced workspace title input for smoother typing responsiveness.
- Debounced terminal directory navigation updates to improve performance.
Chores
- Removed inactive MCP server configurations from settings.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2026-01-07T23:55:47Z

📝 Walkthrough

Walkthrough

The PR removes configured MCP servers from .mcp.json, adds performance documentation, and refactors desktop UI components to use granular store selectors instead of passing entire pane objects as props. Debouncing is added to workspace title and terminal directory updates to reduce excessive re-renders.

Changes

Cohort / File(s)	Summary
Configuration `\.mcp\.json`	Removed neon and morph-warp-grep MCP server configurations; mcpServers now empty.
Documentation `apps/desktop/docs/INPUT_LAG_FIXES\.md`	New file documenting root causes and four implemented fixes for desktop app input lag (granular selectors, selective prop passing, CWD/title debouncing) with testing steps.
Debouncing optimizations `apps/desktop/src/renderer/components/NewWorkspaceModal/NewWorkspaceModal\.tsx` `apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/Terminal\.tsx`	NewWorkspaceModal: added localTitle state with 150ms debounce to title updates; uses localTitle for derived calculations. Terminal: debounced CWD store updates (150ms) and replaced coarse pane access with granular selectors.
Store selector refactoring `apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/FileViewerPane/FileViewerPane\.tsx` `apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/TabPane\.tsx` `apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/index\.tsx` `apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/index\.tsx`	Removed pane prop from components; FileViewerPane and TabPane now derive pane data via granular store selectors (fileViewer, cwd, cwdConfirmed). TabView no longer receives panes prop; derives tabPanes from layout and global store using memoization; passes only paneId to child components. TabsContent simplified to not retrieve/pass panes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

tabs mangement interaction #105: Both PRs modify overlapping TabView/TabsContent/TabPane components and tabs store selectors for the same workspace view refactoring.
feature (desktop):warp style wd nav and terminal path visualization #286: Both PRs modify pane/CWD store interactions (updatePaneCwd, cwdConfirmed properties, DirectoryNavigator), with the main PR adding debouncing to the same flow.
Add dropdown create modal #391: Both PRs modify NewWorkspaceModal component; the related PR introduced modal branchName handling while this adds localTitle debouncing for the same form.

Poem

🐰 Granular selectors hop so spry,
Debounce delays the input sigh,
No panes passed around in props,
Store subscriptions never stop! ✨
Lag fixed with a selective bounds—
Optimized renders, swifter rounds!

🚥 Pre-merge checks | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is entirely empty—only the template structure remains with no filled-in sections for description, related issues, type of change, testing, or additional context.	Complete the PR description template with clear explanations of changes, link related issues, select the appropriate type of change, document testing steps, and add relevant context.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title is vague and uses informal phrasing ('make app go brr') that doesn't clearly convey the specific technical changes made (input lag fixes, debouncing, granular selectors, etc.).	Revise the title to be more specific and descriptive, such as 'fix(desktop): optimize performance with debouncing and granular selectors' or similar.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-01-07T23:56:37Z

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

✅ Neon database branch
⚠️ Electric Fly.io app

Thank you for your contribution! 🎉

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/index.tsx (1)
37-37: Consider more selective store subscription to fully realize performance gains.

While the refactor correctly derives pane data internally, the subscription pattern may limit performance benefits:

Line 37 subscribes to the entire panes object, meaning any pane update in any tab triggers this component to re-render and the tabPanes memo (lines 55-64) to recompute. Additionally, the memo creates a new object each time, so tabPanes will have a new reference even if the content is identical, causing the renderPane callback (line 162) to be recreated and potentially triggering Mosaic re-renders.

For a workspace with many active panes/tabs, this could result in unnecessary work.
Potential optimization approaches

Option 1: Use Zustand's shallow equality or a custom equality function:
+import { shallow } from 'zustand/shallow';

 const tabPanes = useTabsStore(
   (s) => {
     const result: Record<string, { tabId: string; type: string }> = {};
     for (const paneId of layoutPaneIds) {
       const pane = s.panes[paneId];
       if (pane?.tabId === tab.id) {
         result[paneId] = { tabId: pane.tabId, type: pane.type };
       }
     }
     return result;
   },
+  shallow
 );
Note: This approach still subscribes broadly but compares the result to avoid unnecessary updates.

Option 2: Consider a derived selector in the store that pre-computes panes-by-tab to avoid repeated filtering across all tab components.
Also applies to: 49-64, 162-162

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ccf9cdb and 9152eab.

📒 Files selected for processing (8)

.mcp.json
apps/desktop/docs/INPUT_LAG_FIXES.md
apps/desktop/src/renderer/components/NewWorkspaceModal/NewWorkspaceModal.tsx
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/FileViewerPane/FileViewerPane.tsx
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/TabPane.tsx
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/index.tsx
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/Terminal.tsx
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/index.tsx

🧰 Additional context used

📓 Path-based instructions (6)

apps/desktop/**/*.{ts,tsx}

📄 CodeRabbit inference engine (apps/desktop/AGENTS.md)

apps/desktop/**/*.{ts,tsx}: For Electron interprocess communication, ALWAYS use tRPC as defined in src/lib/trpc
Use alias as defined in tsconfig.json when possible
Prefer zustand for state management if it makes sense. Do not use effect unless absolutely necessary.
For tRPC subscriptions with trpc-electron, ALWAYS use the observable pattern from @trpc/server/observable instead of async generators, as the library explicitly checks isObservable(result) and throws an error otherwise

Files:

apps/desktop/src/renderer/components/NewWorkspaceModal/NewWorkspaceModal.tsx
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/index.tsx
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/TabPane.tsx
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/Terminal.tsx
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/FileViewerPane/FileViewerPane.tsx
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/index.tsx

**/*.{ts,tsx}