Clean up Terminal api

[Kitenite]

Description

Related Issues

Type of Change

• Bug fix
• New feature
• Documentation
• Refactor
• Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

• Refactor
  • Terminal handling updated to distinguish pane vs. tab identity for clearer, more consistent behavior.
• Bug Fixes
  • Improved focus management, session attach/restore, and restart flows for terminals to reduce mismatches and race conditions.
• User Experience
  • More reliable title updates and more predictable terminal session restoration across pane/tab changes.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Terminal and its cold-restore hook were changed to accept an explicit paneId in addition to tabId; TabPane invocation and internal references were updated so pane and tab identifiers are passed and used separately across creation, attach, focus, restore, and title-update flows.

Changes

Cohort / File(s)	Summary
Terminal core & types apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/Terminal.tsx, apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/types.ts	Component signature updated to ({ paneId, tabId, workspaceId }); removed local paneId = tabId alias; internal logic now uses both paneId and tabId explicitly; TerminalProps adds paneId: string.
Terminal hook (cold-restore) apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/hooks/useTerminalColdRestore.ts	Hook signature/options now include tabId (removed parentTabIdRef); create/attach payloads and callbacks use explicit tabId; dependency arrays updated.
TabPane usage apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/TabPane.tsx	Invocation of Terminal changed from tabId={paneId} to paneId={paneId} and tabId={tabId}, adapting to the new dual-identifier props.

Estimated Code Review Effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• refactor(desktop): update changes view #595 — Modifies TabPane/Terminal integration and pane/tab prop wiring; overlaps at invocation level.
• feat(desktop): add 3-color workspace status indicators #588 — Alters Terminal component and related types/hooks with similar paneId/tabId propagation changes.
• fix (desktop): make app go brr #659 — Updates pane/tab identifier handling across workspace components; likely touches same callsites and logic.

Poem

🐇 I hopped through panes and tabs today,

clip-clop of keys, a gentle sway.
Now every pane knows its proper name,
tab and pane each play their game.
Bravo — a rabbit's little celebratory nibble! 🥕

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is entirely empty with only the template placeholders remaining; no substantive information was provided by the author.	Complete the description by explaining what props are being renamed, why the change is needed, and confirm testing with the commit message 'Pass tabId'.
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Clean up Terminal api' directly relates to the main change: refactoring Terminal props by replacing tabId aliasing with explicit paneId and tabId props, improving the public API clarity.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch terminal-debug

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

• ⚠️ Neon database branch
• ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉