perf(desktop): use granular selector in WorkspaceListItem to prevent rerenders by Kitenite · Pull Request #672 · superset-sh/superset

Kitenite · 2026-01-08T21:52:00Z

Summary

Replace full tabs and panes store subscriptions with a single granular selector in WorkspaceListItem
Selector computes workspace status directly and returns a primitive value
Prevents all workspace sidebar items from rerendering when any pane status changes

Before: Each WorkspaceListItem subscribed to entire tabs/panes objects, causing ALL workspace items to rerender when ANY pane status changed anywhere in the app.

After: Single selector filters tabs by workspace ID, extracts pane IDs, computes highest priority status, and returns a primitive. Zustand's Object.is equality check prevents rerenders unless the computed status actually changes.

Test plan

Open multiple workspaces in sidebar
Run an agent in one workspace terminal (triggers frequent status changes)
Verify other workspace items don't rerender (use React DevTools Profiler)
Verify status indicator still updates correctly for the active workspace

🤖 Generated with Claude Code

Summary by CodeRabbit

Chores
- Optimized workspace status detection to reduce unnecessary interface updates while maintaining existing functionality and user experience.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

…rerenders Replace full `tabs` and `panes` store subscriptions with a single granular selector that computes workspace status directly and returns a primitive. Before: Each WorkspaceListItem subscribed to entire tabs/panes objects, causing ALL workspace items to rerender when ANY pane status changed. After: Selector filters tabs by workspace ID, extracts pane IDs, and computes highest priority status inside the selector. Returns primitive string/null so Zustand's Object.is equality check prevents rerenders unless the computed status actually changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

coderabbitai · 2026-01-08T21:52:12Z

📝 Walkthrough

Walkthrough

This change refactors workspace status derivation in the WorkspaceListItem component by replacing broad tabs/panes state usage with a granular, memoized selector. A useCallback-based selector now computes workspace status by filtering tabs and aggregating pane statuses. Previous useMemo-based memoization blocks are removed. The component's public API and UI behavior remain unchanged.

Changes

Cohort / File(s)	Change Summary
Workspace Status Selector Refactoring `apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/WorkspaceListItem/WorkspaceListItem.tsx`	Introduces granular useCallback-based selector to derive workspace status by filtering workspace tabs, collecting pane IDs from tab layouts, and computing highest priority status. Removes previous useMemo-based memoization of workspacePaneIds and workspaceStatus. Adds TabsStore type import. Reduces unnecessary re-renders by deriving status via dedicated selector.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

fix (desktop): make app go brr #659 — Implements granular TabsStore selectors across multiple components, replacing coarse global panes/tabs access with per-workspace selectors, aligning with this PR's optimization pattern.
perf(desktop): skip redundant store updates when values unchanged #671 — Adds no-op guards to tabs store actions (e.g., setPaneStatus) that directly affect pane statuses and subscribers, complementing this PR's selector-based status derivation.

Poem

🐰 A selector so fine, with care now we weave,
Memoized just right, no render reprieve,
Workspace status flows clean, through pane-filtered streams,
Each hop more efficient—fulfilling our dreams! 🌟

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: using a granular selector in WorkspaceListItem for performance optimization to prevent unnecessary rerenders.
Description check	✅ Passed	The description provides a comprehensive summary of changes, clear before/after rationale, and a detailed test plan. It covers the key sections of the template with substantive information.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a2451a4 and ca8f654.

📒 Files selected for processing (1)

apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/WorkspaceListItem/WorkspaceListItem.tsx

🧰 Additional context used

📓 Path-based instructions (6)

apps/desktop/**/*.{ts,tsx}

📄 CodeRabbit inference engine (apps/desktop/AGENTS.md)

apps/desktop/**/*.{ts,tsx}: For Electron interprocess communication, ALWAYS use tRPC as defined in src/lib/trpc
Use alias as defined in tsconfig.json when possible
Prefer zustand for state management if it makes sense. Do not use effect unless absolutely necessary.
For tRPC subscriptions with trpc-electron, ALWAYS use the observable pattern from @trpc/server/observable instead of async generators, as the library explicitly checks isObservable(result) and throws an error otherwise

Files:

apps/desktop/src/renderer/screens/main/components/WorkspaceSidebar/WorkspaceListItem/WorkspaceListItem.tsx

**/*.{ts,tsx}