refactor(desktop): tidy v2 terminal session dropdown#3743
Conversation
Drop the timestamp from the trigger title, widen the trigger and menu, push the chevron to the trailing edge, and unify dropdown text sizes.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe TerminalSessionDropdown component simplifies its dropdown trigger by removing current session computation, now displaying only the trigger title. Styling updates include replacing container-query-driven sizing with fixed widths, expanding the dropdown menu width, and adjusting typography sizing for session item labels. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR tidies the v2 terminal session dropdown trigger by removing the time-ago label from the button, widening the trigger ( Confidence Score: 5/5Safe to merge — purely cosmetic UI changes with no logic impact. All changes are Tailwind class adjustments and the removal of two unused variables. No logic, data flow, or API contracts were modified. formatCreatedAt remains in use for dropdown rows, so no dead code is introduced. No files require special attention.
|
| Filename | Overview |
|---|---|
| apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/TerminalPane/components/TerminalSessionDropdown/TerminalSessionDropdown.tsx | UI-only refactor: removes trigger time-ago label, widens trigger/menu, unifies row text sizes to text-xs. No logic changes; formatCreatedAt is still used for dropdown rows. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[TerminalSessionDropdown] --> B[Trigger Button\nmin-w-32 max-w-96]
B --> C[TerminalSquare icon\nshrink-0]
B --> D[Title span\nflex-1 truncate text-left]
B --> E{isFetching && isOpen?}
E -->|Yes| F[LoaderCircle spinner]
E -->|No| G[ChevronDown]
A --> H[DropdownMenuContent\nw-96]
H --> I[Label: Terminal Sessions\ntext-xs]
H --> J[Session rows loop]
J --> K[Check icon if current]
J --> L[Title text-xs]
J --> M[createdAt label\ntext-xs was text-10px]
J --> N[Status text-xs]
J --> O[Remove button]
H --> P[New Terminal item\ntext-xs]
Reviews (1): Last reviewed commit: "refactor(desktop): tidy v2 terminal sess..." | Re-trigger Greptile
# Conflicts: # apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/TerminalPane/components/TerminalSessionDropdown/TerminalSessionDropdown.tsx
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Drop the timestamp from the trigger title, widen the trigger and menu, push the chevron to the trailing edge, and unify dropdown text sizes.
PR1〜PR5 (#435 #436 #437 #438 #440) で 13 commits 全件 cherry-pick + 手動 conflict 解消で取り込み済み。 本コミットは git 履歴上 behind=0 とするための ours マージ記録。 取り込み済み 13 commits: - 1f55c62 Fix host service restart adoption (superset-sh#3732) - 0fe65d2 test(desktop): remove host-service-coordinator test (superset-sh#3734) - 3012b5a Add optimistic Electric collection updates (superset-sh#3722) - c272a51 fix(desktop): drop branch row from v2 sidebar workspace item (superset-sh#3733) - c2f3fdc feat(desktop): add fade-edge mask utilities (superset-sh#3735) - 682d07c fix v2 terminal osc links (superset-sh#3736) - 7c0d22b feat(ports): surface remote host-service ports in the sidebar (superset-sh#3676) - 6a3be2d [codex] Stabilize v2 terminal resize (superset-sh#3739) - 8928ac6 [codex] Improve v2 pane header responsiveness (superset-sh#3737) - 5fe3d22 refactor(desktop): tidy v2 terminal session dropdown (superset-sh#3743) - 66c23d6 Fix automation timezone scheduling (superset-sh#3738) - 16e270c [codex] Add terminal session titles (superset-sh#3740) - 583fa5d fix(desktop): refit v2 terminal after font settle (superset-sh#3742)
Summary
min-w-32 max-w-96) and the menu (w-96), and push the chevron/spinner to the trailing edge viaflex-1on the titletext-xslike the restTest plan
Summary by cubic
Cleans up the v2 terminal session dropdown for a cleaner title and consistent text. Removes the timestamp from the trigger, constrains widths, and aligns the chevron/spinner to the right.
Written for commit e1cffca. Summary will update on new commits.
Summary by CodeRabbit