Skip to content

refactor(desktop): tidy v2 terminal session dropdown#3743

Merged
Kitenite merged 2 commits into
mainfrom
terminal-title-cleanup
Apr 25, 2026
Merged

refactor(desktop): tidy v2 terminal session dropdown#3743
Kitenite merged 2 commits into
mainfrom
terminal-title-cleanup

Conversation

@Kitenite
Copy link
Copy Markdown
Collaborator

@Kitenite Kitenite commented Apr 25, 2026

Summary

  • Drop the time-ago label from the trigger so the selected terminal title reads clean
  • Widen the trigger (min-w-32 max-w-96) and the menu (w-96), and push the chevron/spinner to the trailing edge via flex-1 on the title
  • Unify dropdown row text sizes — the per-row created-at label is now text-xs like the rest

Test plan

  • Open a v2 workspace with multiple terminal sessions and confirm the trigger shows just the title + chevron
  • Open the dropdown and verify all rows (label, title, time, status, "New Terminal") share the same text size
  • Resize the pane narrow/wide and confirm the trigger respects min/max width with the chevron pinned to the right

Summary by cubic

Cleans up the v2 terminal session dropdown for a cleaner title and consistent text. Removes the timestamp from the trigger, constrains widths, and aligns the chevron/spinner to the right.

  • Refactors
    • Remove time-ago label from the trigger; show only the title.
    • Set trigger to min-w-32/max-w-96 and menu to w-96; make title flex-1 to push chevron/spinner to the right.
    • Standardize dropdown row text to text-xs, including the created-at label.

Written for commit e1cffca. Summary will update on new commits.

Summary by CodeRabbit

  • Style
    • Improved terminal session dropdown layout with fixed width sizing for better consistency.
    • Increased dropdown menu width for improved readability.
    • Adjusted typography scaling for session metadata labels.
    • Simplified dropdown trigger display for cleaner appearance.

Drop the timestamp from the trigger title, widen the trigger and
menu, push the chevron to the trailing edge, and unify dropdown text
sizes.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 65c969b4-5248-4d41-b4e4-c7ce3e5a0916

📥 Commits

Reviewing files that changed from the base of the PR and between 8928ac6 and e1cffca.

📒 Files selected for processing (1)
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/TerminalPane/components/TerminalSessionDropdown/TerminalSessionDropdown.tsx

📝 Walkthrough

Walkthrough

The TerminalSessionDropdown component simplifies its dropdown trigger by removing current session computation, now displaying only the trigger title. Styling updates include replacing container-query-driven sizing with fixed widths, expanding the dropdown menu width, and adjusting typography sizing for session item labels.

Changes

Cohort / File(s) Summary
Terminal Session Dropdown UI
apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/TerminalPane/components/TerminalSessionDropdown/TerminalSessionDropdown.tsx
Removed current session lookup for created-at label in dropdown trigger. Updated trigger styling from container-query-based sizing to fixed min/max widths. Increased dropdown menu width from w-80 to w-96. Changed session item label typography from text-[10px] to text-xs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 A dropdown grows wider, the trigger sits clean,
No more session hunting—the simplest I've seen!
Fixed widths instead of queries that roamed,
Typography dancing, label text combed. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'refactor(desktop): tidy v2 terminal session dropdown' clearly and concisely describes the main change: tidying up the v2 terminal session dropdown component with focused refactoring.
Description check ✅ Passed The PR description includes a comprehensive summary of changes, detailed test plan with checkboxes, and includes auto-generated summary. However, it is missing explicit sections matching the template (Related Issues, Type of Change are absent or incomplete).
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch terminal-title-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 25, 2026

Greptile Summary

This PR tidies the v2 terminal session dropdown trigger by removing the time-ago label from the button, widening the trigger (min-w-32 max-w-96) and menu (w-96), pinning the chevron/spinner to the trailing edge with flex-1, and unifying all dropdown row text sizes to text-xs. The changes are purely cosmetic/layout with no logic alterations.

Confidence Score: 5/5

Safe to merge — purely cosmetic UI changes with no logic impact.

All changes are Tailwind class adjustments and the removal of two unused variables. No logic, data flow, or API contracts were modified. formatCreatedAt remains in use for dropdown rows, so no dead code is introduced.

No files require special attention.

Important Files Changed

Filename Overview
apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/TerminalPane/components/TerminalSessionDropdown/TerminalSessionDropdown.tsx UI-only refactor: removes trigger time-ago label, widens trigger/menu, unifies row text sizes to text-xs. No logic changes; formatCreatedAt is still used for dropdown rows.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[TerminalSessionDropdown] --> B[Trigger Button\nmin-w-32 max-w-96]
    B --> C[TerminalSquare icon\nshrink-0]
    B --> D[Title span\nflex-1 truncate text-left]
    B --> E{isFetching && isOpen?}
    E -->|Yes| F[LoaderCircle spinner]
    E -->|No| G[ChevronDown]
    A --> H[DropdownMenuContent\nw-96]
    H --> I[Label: Terminal Sessions\ntext-xs]
    H --> J[Session rows loop]
    J --> K[Check icon if current]
    J --> L[Title text-xs]
    J --> M[createdAt label\ntext-xs was text-10px]
    J --> N[Status text-xs]
    J --> O[Remove button]
    H --> P[New Terminal item\ntext-xs]
Loading

Reviews (1): Last reviewed commit: "refactor(desktop): tidy v2 terminal sess..." | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

# Conflicts:
#	apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/TerminalPane/components/TerminalSessionDropdown/TerminalSessionDropdown.tsx
@Kitenite Kitenite merged commit 5fe3d22 into main Apr 25, 2026
7 checks passed
@Kitenite Kitenite deleted the terminal-title-cleanup branch April 25, 2026 22:14
@github-actions
Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ⚠️ Neon database branch

Thank you for your contribution! 🎉

MocA-Love pushed a commit to MocA-Love/superset that referenced this pull request Apr 26, 2026
Drop the timestamp from the trigger title, widen the trigger and
menu, push the chevron to the trailing edge, and unify dropdown text
sizes.
MocA-Love added a commit to MocA-Love/superset that referenced this pull request Apr 26, 2026
PR1〜PR5 (#435 #436 #437 #438 #440) で 13 commits 全件 cherry-pick + 手動 conflict 解消で取り込み済み。
本コミットは git 履歴上 behind=0 とするための ours マージ記録。

取り込み済み 13 commits:
- 1f55c62 Fix host service restart adoption (superset-sh#3732)
- 0fe65d2 test(desktop): remove host-service-coordinator test (superset-sh#3734)
- 3012b5a Add optimistic Electric collection updates (superset-sh#3722)
- c272a51 fix(desktop): drop branch row from v2 sidebar workspace item (superset-sh#3733)
- c2f3fdc feat(desktop): add fade-edge mask utilities (superset-sh#3735)
- 682d07c fix v2 terminal osc links (superset-sh#3736)
- 7c0d22b feat(ports): surface remote host-service ports in the sidebar (superset-sh#3676)
- 6a3be2d [codex] Stabilize v2 terminal resize (superset-sh#3739)
- 8928ac6 [codex] Improve v2 pane header responsiveness (superset-sh#3737)
- 5fe3d22 refactor(desktop): tidy v2 terminal session dropdown (superset-sh#3743)
- 66c23d6 Fix automation timezone scheduling (superset-sh#3738)
- 16e270c [codex] Add terminal session titles (superset-sh#3740)
- 583fa5d fix(desktop): refit v2 terminal after font settle (superset-sh#3742)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant