Skip to content

refactor(desktop): tidy v2 terminal session dropdown #3743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kitenite merged 2 commits into from
Apr 25, 2026
Merged

refactor(desktop): tidy v2 terminal session dropdown #3743

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1dba16
refactor(desktop): tidy v2 terminal session dropdown
Kitenite Apr 25, 2026
e1cffca
Merge remote-tracking branch 'origin/main' into terminal-title-cleanup
Kitenite Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions ...ry/components/TerminalPane/components/TerminalSessionDropdown/TerminalSessionDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,10 +203,6 @@ export function TerminalSessionDropdown({
};

const triggerTitle = context.pane.titleOverride ?? "Terminal";
const currentSession = sessions.find(
(session) => session.terminalId === terminalId,
);
const currentCreatedAtLabel = formatCreatedAt(currentSession?.createdAt);

return (
<DropdownMenu open={isOpen} onOpenChange={setIsOpen}>
Expand All @@ -215,14 +211,13 @@ export function TerminalSessionDropdown({
type="button"
aria-label="Terminal sessions"
title={triggerTitle}
className="@container/terminal-session flex min-w-0 max-w-full flex-1 items-center gap-1.5 rounded px-1.5 py-0.5 text-xs text-muted-foreground transition-colors hover:bg-muted hover:text-foreground"
className="flex min-w-32 max-w-96 items-center gap-1.5 rounded px-1.5 py-0.5 text-xs text-muted-foreground transition-colors hover:bg-muted hover:text-foreground"
onMouseDown={(event) => event.stopPropagation()}
onClick={(event) => event.stopPropagation()}
>
<TerminalSquare className="size-3.5 shrink-0" />
<span className="min-w-0 truncate">{triggerTitle}</span>
<span className="hidden shrink-0 text-[10px] text-muted-foreground/70 @min-[160px]/terminal-session:inline">
{currentCreatedAtLabel}
<span className="min-w-0 flex-1 truncate text-left">
{triggerTitle}
</span>
{sessionsQuery.isFetching && isOpen ? (
<LoaderCircle className="size-3 shrink-0 animate-spin" />
Expand All @@ -231,7 +226,7 @@ export function TerminalSessionDropdown({
)}
</button>
</DropdownMenuTrigger>
<DropdownMenuContent align="start" className="w-80">
<DropdownMenuContent align="start" className="w-96">
<DropdownMenuLabel className="text-xs">
Terminal Sessions
</DropdownMenuLabel>
Expand Down Expand Up @@ -269,7 +264,7 @@ export function TerminalSessionDropdown({
<span className="min-w-0 flex-1 truncate text-xs">
{title}
</span>
<span className="shrink-0 text-[10px] text-muted-foreground/70">
<span className="shrink-0 text-xs text-muted-foreground/70">
{createdAtLabel}
</span>
<span className="shrink-0 text-xs text-muted-foreground">
Expand Down
Loading