test(desktop): remove host-service-coordinator test that pollutes other tests

[Kitenite]

Summary

The test added in #3732 calls mock.module() for node:child_process and shell-env. Bun hoists these globally and there's no per-file isolation — they persist for the entire bun test process. This caused 17 unrelated tests (merge-pull-request, git, teardown, listExternalWorktrees, Shell Environment) to fail or timeout when run in the full suite.

I tried less invasive fixes (spreading actual exports, re-mocking in afterAll, removing just the shell-env mock) — none restored live ESM bindings already captured by other test files. Deleting the test is the only mechanical fix.

The product fix in host-service-coordinator.ts (#3732) is unchanged. Coverage should be restored via a refactor that injects spawn / getProcessEnvWithShellPath as constructor options rather than mocking modules globally.

Result

• Full local bun test: 1830 pass / 0 fail (was 1739 pass / 7 fail / 6 errors on main)

Test plan

• CI Test job passes on this branch

Summary by CodeRabbit

• Tests
  • Removed an existing test suite for the host service coordinator, including its network fetch setup/teardown and multiple scenarios around process adoption and spawning.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2fd51e2a-2e38-4311-a7bf-b98e0f27ffa4

📥 Commits

Reviewing files that changed from the base of the PR and between 41de282 and fd3589f.

📒 Files selected for processing (1)

• apps/desktop/src/main/lib/host-service-coordinator.test.ts

💤 Files with no reviewable changes (1)

• apps/desktop/src/main/lib/host-service-coordinator.test.ts

---

📝 Walkthrough

Walkthrough

A test file apps/desktop/src/main/lib/host-service-coordinator.test.ts was removed; the deletion included mocks and tests that exercised HostServiceCoordinator.start under multiple scenarios and managed global fetch setup/teardown.

Changes

Cohort / File(s)	Summary
Removed Test File apps/desktop/src/main/lib/host-service-coordinator.test.ts	Deleted full test suite that mocked node:child_process, @superset/shared/device-info, local helpers (shell-env, host-service-manifest, host-service-utils), exercised HostServiceCoordinator.start across three scenarios (spawn detached, adopt existing manifest, reject outdated manifest), and managed globalThis.fetch setup/teardown.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 I hopped into tests and found a file gone,

Left a quiet burrow at the break of dawn.
Mocks and scenarios packed up and hopped away,
I nibble on crumbs of legacy today. 🥕

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: removing a problematic test that causes pollution in other tests.
Description check	✅ Passed	The description provides clear context about the test pollution issue, attempts made, and the solution, but lacks some template structure.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-merge-pull-request-test

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[greptile-apps]

Greptile Summary

This PR fixes a process-wide mock pollution bug in host-service-coordinator.test.ts where mock.module() for shell-env only exported getProcessEnvWithShellPath, stripping all other exports (execWithShellEnv, getShellEnvironment, etc.) from subsequent tests in the same Bun process. The fix spreads ...actualShellEnv into the mock factory — identical to the existing pattern used for node:child_process in the same file — so only the one function is overridden.

Confidence Score: 5/5

Safe to merge — minimal, targeted fix with no logic changes and no new risks.

The change is a two-line addition that follows the established pattern already present in this file. It restores broken test isolation without altering any production code. No P0/P1 findings.

No files require special attention.

Important Files Changed

Filename	Overview
apps/desktop/src/main/lib/host-service-coordinator.test.ts	Imports actualShellEnv and spreads it into the mock.module factory so only getProcessEnvWithShellPath is overridden, preserving all other exports for subsequent tests.

Sequence Diagram

sequenceDiagram
    participant Bun as Bun Test Runner
    participant HSC as host-service-coordinator.test.ts
    participant MPR as merge-pull-request.test.ts
    participant SE as shell-env module

    Note over Bun: Before fix
    HSC->>SE: mock.module({ getProcessEnvWithShellPath })
    Note over SE: Only getProcessEnvWithShellPath exported
    MPR->>SE: import { execWithShellEnv }
    SE-->>MPR: SyntaxError: Export named 'execWithShellEnv' not found

    Note over Bun: After fix
    HSC->>SE: import * as actualShellEnv
    HSC->>SE: mock.module({ ...actualShellEnv, getProcessEnvWithShellPath })
    Note over SE: All real exports preserved, only getProcessEnvWithShellPath overridden
    MPR->>SE: import { execWithShellEnv }
    SE-->>MPR: resolves successfully

Loading

_{Reviews (1): Last reviewed commit: "fix(desktop): preserve real shell-env ex..." | Re-trigger Greptile}

[cubic-dev-ai]

No issues found across 1 file

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

• ⚠️ Neon database branch

Thank you for your contribution! 🎉