update ringtone files

[Kitenite]

Summary by CodeRabbit

• New Features
  • Added a new ringtone option to the available selections
  • Updated the default ringtone selection

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Updated the built-in ringtone catalog by replacing the first entry from "default/Bango" to "shamisen/Shamisen" with corresponding filename and emoji updates, and changed the DEFAULT_RINGTONE_ID constant from "default" to "arcade".

Changes

Cohort / File(s)	Summary
Ringtone Configuration apps/desktop/src/shared/ringtones.ts	Replaced first ringtone entry (id, name, description, filename, emoji) and updated DEFAULT_RINGTONE_ID constant from "default" to "arcade"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

This is a straightforward configuration update with no logic changes, function signature modifications, or control flow alterations.

Possibly related PRs

• fix (desktop): add default ringtone and rename some to be more pc #325 — Modifies the same ringtone catalog and default configuration in apps/desktop/src/shared/ringtones.ts

Poem

🐰 A shamisen now plays so sweet,
Where bango once rang, hear its beat!
From default to arcade we stray,
New melodies brighten the day! 🪕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided by the author, despite a clear template being available in the repository.	Provide a complete pull request description following the template, including a clear description of the changes, related issues, type of change, and any relevant testing or additional notes.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'update ringtone files' is directly related to the main change in the changeset, which replaces and updates ringtone entries in the ringtones.ts file.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch zoophagous-cockroach-ec48e0

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 28869bc and 49f6d98.

⛔ Files ignored due to path filters (1)

• apps/desktop/src/resources/sounds/shamisen.mp3 is excluded by !**/*.mp3

📒 Files selected for processing (1)

• apps/desktop/src/shared/ringtones.ts (2 hunks)

🧰 Additional context used

📓 Path-based instructions (4)

apps/desktop/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (apps/desktop/AGENTS.md)

For Electron interprocess communication, ALWAYS use tRPC as defined in src/lib/trpc

Files:

• apps/desktop/src/shared/ringtones.ts

apps/desktop/**/*.{ts,tsx}

📄 CodeRabbit inference engine (apps/desktop/AGENTS.md)

apps/desktop/**/*.{ts,tsx}: Please use alias as defined in tsconfig.json when possible
Prefer zustand for state management if it makes sense. Do not use effect unless absolutely necessary

Files:

• apps/desktop/src/shared/ringtones.ts

**/*.{ts,tsx,js,jsx,json}

📄 CodeRabbit inference engine (AGENTS.md)

Use Biome for code formatting and linting, running at root level for speed

Files:

• apps/desktop/src/shared/ringtones.ts

**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Avoid any type and prioritize type safety in TypeScript code

Files:

• apps/desktop/src/shared/ringtones.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: Deploy Admin
• GitHub Check: Deploy Web
• GitHub Check: Deploy Marketing
• GitHub Check: Deploy API
• GitHub Check: Deploy Docs
• GitHub Check: Build

🔇 Additional comments (1)

apps/desktop/src/shared/ringtones.ts (1)

23-30: Ensure the new ringtone asset is present and packaged (shamisen.mp3).

Code change is fine, but filename: "shamisen.mp3" will break at runtime if the asset isn’t in src/resources/sounds/ (and included in the build).

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Default ringtone change may need migration for existing persisted settings.

If user preferences can persist DEFAULT_RINGTONE_ID (or previously stored "default"), consider handling the legacy "default" id by mapping it to "shamisen" (or "arcade") to avoid falling back to silent/empty filename.

🤖 Prompt for AI Agents

In apps/desktop/src/shared/ringtones.ts around line 131, the exported
DEFAULT_RINGTONE_ID was changed to "arcade" but existing persisted user prefs
may still contain the legacy id "default"; update the ringtone-loading/migration
logic so that when reading persisted ringtone ids you map "default" to the new
canonical id (choose "shamisen" or "arcade" — use "shamisen" if you want
previous behavior or "arcade" to adopt the new default), replace the stored
value with the mapped id (write-back) and fall back to DEFAULT_RINGTONE_ID only
if no valid id is present; ensure the mapping is applied wherever persisted
prefs are deserialized.

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

Service	Status
Database (Neon)	✅

Thank you for your contribution! 🎉

---

Preview resources have been processed for cleanup