Skip to content

fix: create PR on release script and prevent creating extra draft release#376

Merged
Kitenite merged 1 commit intomainfrom
dry-dragonfly-c7ad75
Dec 16, 2025
Merged

fix: create PR on release script and prevent creating extra draft release#376
Kitenite merged 1 commit intomainfrom
dry-dragonfly-c7ad75

Conversation

@Kitenite
Copy link
Copy Markdown
Collaborator

@Kitenite Kitenite commented Dec 15, 2025

Summary by CodeRabbit

  • Chores
    • Optimized desktop application release workflow to prevent duplicate releases during the build process.
    • Enhanced release management with improved pull request handling for streamlined release operations.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Dec 15, 2025

Walkthrough

The desktop app release process is modified to prevent electron-builder from publishing its own release and to remove the GH_TOKEN from the build step, while the release script now creates or checks for PRs prior to tagging when on non-main branches.

Changes

Cohort / File(s) Summary
Release workflow configuration
.github/workflows/release-desktop.yml
Added --publish never flag to the Build Electron app step to prevent electron-builder from creating its own release; removed GH_TOKEN from the bun run command invocation; added clarifying comments that the release job handles GitHub release creation.
Release script enhancement
apps/desktop/create-release.sh
Introduced PR workflow logic that checks for and creates PRs before tagging when the current branch is not main; includes PR URL capture and basic error handling; preserves existing tag creation, remote push, and GitHub Actions workflow monitoring steps.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Verify PR creation logic handles edge cases (PR already exists, API failures)
  • Confirm GH_TOKEN removal does not break authentication in downstream steps
  • Validate --publish never flag prevents electron-builder from competing with GitHub Actions release creation

Possibly related PRs

  • #131: Modifies the same .github/workflows/release-desktop.yml file and affects desktop app packaging behavior.
  • #144: Updates both .github/workflows/release-desktop.yml and apps/desktop/create-release.sh in the desktop release workflow.
  • #203: Modifies apps/desktop/create-release.sh and alters the repository's release flow with publish/draft behavior changes.

Poem

🐰 A token slips away, no publish clash today,
The script now checks for PRs before the tag can play—
Release flows clean and true, with safety built in too! 🚀

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided by the author. Add a detailed PR description following the template with sections: Description, Related Issues, Type of Change, Testing, and any Additional Notes relevant to your changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: creating PR on release script and preventing extra draft release, matching the modifications in both workflow and script files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dry-dragonfly-c7ad75

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 15, 2025

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

Service Status
Neon Database (Neon)

Thank you for your contribution! 🎉


Preview resources have been processed for cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant