Skip to content

Use shadcn tooltips#394

Merged
Kitenite merged 2 commits into
mainfrom
artificial-aphid-623935
Dec 17, 2025
Merged

Use shadcn tooltips#394
Kitenite merged 2 commits into
mainfrom
artificial-aphid-623935

Conversation

@Kitenite
Copy link
Copy Markdown
Collaborator

@Kitenite Kitenite commented Dec 17, 2025

Summary by CodeRabbit

  • Improvements
    • Enhanced user experience with consistent tooltips across the interface. Action buttons and controls now display helpful contextual information on hover, including descriptions and keyboard shortcuts, improving discoverability and usability throughout the application.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Dec 17, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request replaces native HTML title attributes with custom Tooltip components across seven desktop UI files. The changes consistently import Tooltip utilities and wrap action buttons with TooltipTrigger and TooltipContent elements to provide consistent tooltip styling and accessibility throughout the application.

Changes

Cohort / File(s) Change Summary
Tooltip Integration in Quick Add & Presets
apps/desktop/src/renderer/screens/main/components/SettingsView/PresetsSettings/PresetsSettings.tsx
Wrapped Quick Add template buttons with Tooltip components; replaced inline title attributes with TooltipContent displaying "Already added" or template description text positioned bottom-side without arrow.
Tooltip Integration in Pane Actions
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/TabPane.tsx
Added Tooltip wrappers to Split pane and Close pane action buttons; replaced title attributes with bottom-side TooltipContent elements without arrows.
Tooltip Integration in Terminal Navigation
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/DirectoryNavigator/DirectoryNavigator.tsx
Wrapped Navigate button with Tooltip component displaying "Navigate here" on hover; positioned right-side without arrow. Removed title attribute.
Tooltip Integration in Terminal Search
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/TerminalSearch/TerminalSearch.tsx
Replaced three standalone buttons (Previous, Next, Close) with Tooltip-wrapped versions; moved descriptive text with keyboard shortcuts into TooltipContent elements.
Tooltip Consolidation in File Listing
apps/desktop/src/renderer/screens/main/components/WorkspaceView/Sidebar/ChangesView/components/FileItem/FileItem.tsx
Removed title attribute from file name span; existing Tooltip mechanism now exclusively handles file path display on hover via custom TooltipContent.
Tooltip Integration in Mode Navigation
apps/desktop/src/renderer/screens/main/components/WorkspaceView/Sidebar/ModeCarousel/ModeNavigation.tsx
Wrapped each mode button with TooltipTrigger; replaced button title attributes with TooltipContent displaying mode labels on hover. Preserved click handlers and active-state styling.
Tooltip Integration in Tab Attention Indicator
apps/desktop/src/renderer/screens/main/components/WorkspaceView/Sidebar/TabsView/TabItem/index.tsx
Replaced inline needs-attention markup (animated span with red dot) with Tooltip-based approach; now displays "Agent completed" message via right-side TooltipContent while preserving visual indicator and conditional rendering.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

This PR follows a consistent, homogeneous refactoring pattern across multiple files. All changes replace native title attributes with Tooltip components without introducing new logic or altering control flow. The repetitive nature of the pattern reduces per-file review complexity, though the number of affected files moderately increases total scope.

Possibly related PRs

Poem

🐰 A tooltip tale, so neat and spry,
Where hover hints now catch the eye,
From title tags to styled boxes bright,
Each button blessed with helpful light,
Consistency hops across the screen!

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch artificial-aphid-623935

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between adfda50 and 2ea7648.

📒 Files selected for processing (7)
  • apps/desktop/src/renderer/screens/main/components/SettingsView/PresetsSettings/PresetsSettings.tsx (2 hunks)
  • apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/TabView/TabPane.tsx (2 hunks)
  • apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/DirectoryNavigator/DirectoryNavigator.tsx (2 hunks)
  • apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/TerminalSearch/TerminalSearch.tsx (1 hunks)
  • apps/desktop/src/renderer/screens/main/components/WorkspaceView/Sidebar/ChangesView/components/FileItem/FileItem.tsx (1 hunks)
  • apps/desktop/src/renderer/screens/main/components/WorkspaceView/Sidebar/ModeCarousel/ModeNavigation.tsx (2 hunks)
  • apps/desktop/src/renderer/screens/main/components/WorkspaceView/Sidebar/TabsView/TabItem/index.tsx (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 17, 2025

🚀 Preview Deployment

🔗 Preview Links

Service Status Link
Neon Database (Neon) View Branch
Vercel API (Vercel) Open Preview
Vercel Web (Vercel) Open Preview
Vercel Marketing (Vercel) Open Preview
Vercel Admin (Vercel) Open Preview
Vercel Docs (Vercel) Open Preview

Preview updates automatically with new commits

@Kitenite Kitenite merged commit c93c307 into main Dec 17, 2025
5 checks passed
@Kitenite Kitenite deleted the artificial-aphid-623935 branch December 18, 2025 01:31
This was referenced Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant