fix(desktop): remove PreToolUse/PostToolUse hooks from Codex

[Kitenite]

Summary

• Removes PreToolUse and PostToolUse from the managed Codex hooks in ~/.codex/hooks.json
• Codex now only gets SessionStart, UserPromptSubmit, and Stop hooks
• User-defined PreToolUse/PostToolUse hooks are still preserved during merge

Test plan

• All 25 agent-wrappers tests pass
• Verify Codex sessions still receive start/stop/prompt notifications

---

Summary by cubic

Remove PreToolUse and PostToolUse from managed Codex hooks to cut overhead. Codex now only registers SessionStart, UserPromptSubmit, and Stop, while preserving any user-defined pre/post hooks on merge.

• Bug Fixes
  • Stop injecting PreToolUse/PostToolUse into ~/.codex/hooks.json; only manage SessionStart, UserPromptSubmit, Stop.
  • Preserve user-defined pre/post hooks during merges.
  • Update docs and tests to reflect the new hook set and verify behavior.

^{Written for commit 8a385df. Summary will update on new commits.}

Summary by CodeRabbit

• Chores
  • Updated Codex hooks management to streamline automatically managed lifecycle entries, now limited to SessionStart, UserPromptSubmit, and Stop.
  • Removed PreToolUse and PostToolUse from the set of managed hook events.

[coderabbitai]

📝 Walkthrough

Walkthrough

Removed PreToolUse and PostToolUse from Superset's managed Codex hook event set. The system now manages only three lifecycle events: SessionStart, UserPromptSubmit, and Stop. Changes span documentation, implementation, and test expectations.

Changes

Cohort / File(s)	Summary
Documentation Update apps/desktop/docs/EXTERNAL_FILES.md	Updated managed Codex hook entries list to reflect removal of PreToolUse and PostToolUse; retained SessionStart, UserPromptSubmit, and Stop.
Hook Event Management apps/desktop/src/main/lib/agent-setup/agent-wrappers-claude-codex-opencode.ts	Narrowed managedEvents type definition and removed hook configuration entries for PreToolUse and PostToolUse from the global hooks merge function.
Test Expectations apps/desktop/src/main/lib/agent-setup/agent-wrappers.test.ts	Updated test assertions to verify managed hooks apply only to SessionStart, UserPromptSubmit, and Stop; added explicit checks that PreToolUse and PostToolUse remain unmanaged; removed dedicated test case for multi-event injection.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Two hooks hop away, now just three remain,
SessionStart, Prompt, and Stop—simple and plain,
The codex grows leaner, more nimble and bright,
With fewer concerns, the path forward feels right! 🎯

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description covers the main changes, test status, and includes a summary section, but lacks explicit sections matching the template structure (Related Issues, Type of Change, Testing details, Screenshots, Additional Notes).	Add structured sections including Related Issues (if any), explicitly check Type of Change checkboxes, expand Testing with verification details, and clarify if screenshots apply.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: removing PreToolUse/PostToolUse hooks from Codex, which aligns with the primary modifications across all three files.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch kiet/remove-codex-pre-post-tool-hooks

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

apps/desktop/src/main/lib/agent-setup/agent-wrappers-claude-codex-opencode.ts (1)

368-389: ⚠️ Potential issue | 🟡 Minor

Fix stale comment example near Codex stale-hook cleanup.

Line 369 says “for example UserPromptSubmit from older builds,” but UserPromptSubmit is still actively managed at Line 388. This comment should be updated to avoid confusion.

🧹 Proposed comment fix

-	// Remove all stale Superset-managed Codex hook commands, including events we
-	// no longer manage natively (for example UserPromptSubmit from older builds).
+	// Remove all stale Superset-managed Codex hook commands, including events we
+	// no longer manage natively (for example PreToolUse/PostToolUse from older builds).

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@apps/desktop/src/main/lib/agent-setup/agent-wrappers-claude-codex-opencode.ts`
around lines 368 - 389, The comment above the loop that cleans stale
Superset-managed Codex hook commands is misleading because it says "for example
UserPromptSubmit from older builds" while UserPromptSubmit is still managed (see
managedEvents and the "UserPromptSubmit" tag); update the comment to remove that
example or replace it with an accurate example (or say “events no longer managed
natively” without naming UserPromptSubmit) so it no longer contradicts the code
that uses existing.hooks, removeManagedHooksFromDefinition,
isManagedCodexHookCommand, and the managedEvents list.

apps/desktop/docs/EXTERNAL_FILES.md (1)

45-54: ⚠️ Potential issue | 🟡 Minor

Update Codex paragraph wording to match removed tool hooks.

Line 45 correctly narrows managed Codex hooks, but Line 48-49 still says “prompt/tool lifecycle events,” which is now misleading after removing PreToolUse/PostToolUse.

✏️ Proposed doc tweak

-For Codex specifically, Superset now relies on native `~/.codex/hooks.json`
-registration for durable prompt/tool lifecycle events, while the wrapper in
+For Codex specifically, Superset now relies on native `~/.codex/hooks.json`
+registration for durable prompt/session lifecycle events, while the wrapper in

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/desktop/docs/EXTERNAL_FILES.md` around lines 45 - 54, Update the
paragraph that currently reads “prompt/tool lifecycle events” to remove any
reference to tool hooks and the removed PreToolUse/PostToolUse hooks: change it
to say Superset relies on native hooks.json registration for durable prompt
lifecycle events (SessionStart, UserPromptSubmit, Stop), and clarify that the
Superset wrapper still injects notify and keeps the session-log watcher for
compatibility; also ensure the sentence about rewriting only Superset-managed
entries to point at notify.sh while preserving user-defined hooks remains
accurate.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@apps/desktop/docs/EXTERNAL_FILES.md`:
- Around line 45-54: Update the paragraph that currently reads “prompt/tool
lifecycle events” to remove any reference to tool hooks and the removed
PreToolUse/PostToolUse hooks: change it to say Superset relies on native
hooks.json registration for durable prompt lifecycle events (SessionStart,
UserPromptSubmit, Stop), and clarify that the Superset wrapper still injects
notify and keeps the session-log watcher for compatibility; also ensure the
sentence about rewriting only Superset-managed entries to point at notify.sh
while preserving user-defined hooks remains accurate.

In
`@apps/desktop/src/main/lib/agent-setup/agent-wrappers-claude-codex-opencode.ts`:
- Around line 368-389: The comment above the loop that cleans stale
Superset-managed Codex hook commands is misleading because it says "for example
UserPromptSubmit from older builds" while UserPromptSubmit is still managed (see
managedEvents and the "UserPromptSubmit" tag); update the comment to remove that
example or replace it with an accurate example (or say “events no longer managed
natively” without naming UserPromptSubmit) so it no longer contradicts the code
that uses existing.hooks, removeManagedHooksFromDefinition,
isManagedCodexHookCommand, and the managedEvents list.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 897231a9-53ce-4184-a290-17d09f292034

📥 Commits

Reviewing files that changed from the base of the PR and between 9fa1c6b and 8a385df.

📒 Files selected for processing (3)

• apps/desktop/docs/EXTERNAL_FILES.md
• apps/desktop/src/main/lib/agent-setup/agent-wrappers-claude-codex-opencode.ts
• apps/desktop/src/main/lib/agent-setup/agent-wrappers.test.ts

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

• ⚠️ Neon database branch
• ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉